Conversation
Python API breakage checks — ✅ PASSEDResult: ✅ PASSED |
REST API breakage checks (OpenAPI) — ✅ PASSEDResult: ✅ PASSED |
Coverage Report •
|
||||||||||||||||||||||||||||||||||||||||
Co-authored-by: OpenHands Bot <contact@all-hands.dev>
all-hands-bot
left a comment
There was a problem hiding this comment.
Taste Rating
🟡 Acceptable - Solid architectural refactoring with good backward compatibility handling.
Assessment
The core changes are sound:
- Separating browser capabilities into a dedicated
web-researcheragent eliminates the confusingcli_modeboolean logic - The
cli_mode → enable_browserrename is much clearer (no more inverted semantics) - Backward compatibility properly handled via deprecation mapping with version info
- Test coverage is comprehensive - verifies both name mapping AND tool correctness
Verdict
✅ Code quality is solid - Implementation is correct, tests are thorough, no critical issues found.
All previously identified issues have been resolved. The architectural separation is good engineering taste.
all-hands-bot
left a comment
There was a problem hiding this comment.
This PR modifies agent behavior (prompts, tool assignments, agent routing) and should NOT be auto-approved per repo guidelines. A human maintainer must review after considering evaluation impact.
Assessment: All previously identified issues have been resolved. The architectural change (separating general-purpose from browser-specific agents) is solid and the backward compatibility handling is correct. However, this changes core agent behavior and requires eval verification before merging.
|
[Automatic Post]: This PR seems to be currently waiting for review. @enyst, could you please take a look when you have a chance? |
|
[Automatic Post]: It has been a while since there was any activity on this PR. @VascoSch92, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up. |
|
@enyst :-) Would be nice to merge that. The subagents that we have now are not so good. And I would like to merge that before we have TaskToolSet in cloud. (because of backward compatibility). Do you have blockers or things i should change? |
enyst
left a comment
There was a problem hiding this comment.
Thank you, and sorry for the delay. It looks good and it's localized in subagents, time for fun! ❤️
Summary
This PR changes the built-in subagents available to the main agent.
Motivation
After various rounds of evaluation, a few issues came up:
Solution
Other
Checklist
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.13-nodejs22-slimgolang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:e46fbb0-pythonRun
All tags pushed for this build
About Multi-Architecture Support
e46fbb0-python) is a multi-arch manifest supporting both amd64 and arm64e46fbb0-python-amd64) are also available if needed