Skip to content

Don't raise "Clicked node is undefined" error#388

Merged
annehaley merged 1 commit into
masterfrom
undef-feature-err
May 19, 2026
Merged

Don't raise "Clicked node is undefined" error#388
annehaley merged 1 commit into
masterfrom
undef-feature-err

Conversation

@annehaley
Copy link
Copy Markdown
Collaborator

This PR removes a statement in MapTooltip.vue where an error is raised due to the clicked feature being undefined, but there are circumstances in which we expect this to be the case, so this error should not be raised.

This Sentry error is an example. The following steps reproduce this case:

  • Add the MBTA Rapid Transit layer to the map
  • Click on any node to view the tooltip
  • Without dismissing the tooltip, toggle the visibility of the layer (the error will occur on master and will not occur on this branch)

With this change, updateClickedFeatureIsDeactivatedNode is a no-op when clickedFeature.value is undefined. When the layer containing the clicked feature disappears, the tooltip will disappear, too. It will only reappear when the next feature is clicked.

@annehaley annehaley requested a review from BryonLewis May 19, 2026 12:59
Copy link
Copy Markdown
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@annehaley annehaley merged commit 679cee3 into master May 19, 2026
4 checks passed
@annehaley annehaley deleted the undef-feature-err branch May 19, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants