Improvements to FX Option Template#2758
Merged
mergify[bot] merged 3 commits intomainfrom Mar 11, 2026
Merged
Conversation
skitini
reviewed
Jan 7, 2026
| private static Triple<Double, Double, CurrencyPair> parseNotionalAndStrike( | ||
| CsvRow row, | ||
| PutCall putCall, | ||
| double notional1, |
Contributor
There was a problem hiding this comment.
Could remove the notional1 parsing from parseRow() and do in this method given it's only used as an argment to this method and not used otherwise. Likewise for ccy1 and ccy2
skitini
approved these changes
Feb 25, 2026
14 tasks
Contributor
Merge Queue Status
This pull request spent 8 minutes 36 seconds in the queue, including 8 minutes 20 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.