test(api): baseURL path-prefix coverage + ContentCache indent fix#3
Merged
Merged
Conversation
…ndent The request(path:) URL builder already preserves a baseURL path prefix (e.g. https://host/feedback), but it had no regression test. Add one asserting the prefix is joined ahead of the API path. Also fix the mis-indented ContentCache.init that landed at column 0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
testListPostsPreservesBaseURLPathPrefix— asserts that abaseURLcarrying a path prefix (e.g.https://host/feedback) is preserved when building request URLs (/feedback/api/public/v1/posts). Therequest(path:)join already does this correctly onmain; this locks in the behavior. The no-prefix case stays covered by the existingtestListPostsParsesEnvelope.ContentCache.initand its body had landed at column 0; re-indented to match the surrounding type.Why
The other recent fixes (OTP error surfacing,
needsSignInreset on submit/vote/comment) already have regression tests onmain. The path-prefix branch ofrequest(path:)was the one behavior with no test, and the cache init was a stray formatting bug.Verification
swift test→ 85 tests, 0 failuresswiftlint --stricton changed files → 0 violations🤖 Generated with Claude Code