[php-nextgen] Fix for enum allowed values, fixes #23813#23814
Open
coffeemakr wants to merge 4 commits into
Open
[php-nextgen] Fix for enum allowed values, fixes #23813#23814coffeemakr wants to merge 4 commits into
coffeemakr wants to merge 4 commits into
Conversation
Member
|
thanks for the PR cc @jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12) cc @JulianVennen (top contributor to php-nextgen) |
JulianVennen
approved these changes
May 18, 2026
Contributor
JulianVennen
left a comment
There was a problem hiding this comment.
I think the entire discriminator stuff in nextgen has to be overhauled at some point as it doesn't really work the way it should.
The object serializer always returns a PetAnimal, because:
- The
mappingkey is not implemented. Discriminator values have to be the literal class name of the model - The generated classes are not children of the PetAnimal class.
In other generators (e.g. typescript) those work correctly.
That being said, this PR does seem to be an improvement for now until someone has time and motivation to implement the discriminator stuff properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Fixes incorrect enum allowed values in
php-nextgenmodels and restores missing discriminator constants. Prevents mixing discriminator values into unrelated enums. Fixes #23813.model_generic.mustacheto handle enums separately for discriminator vs non-discriminator fields and preserve discriminator constants.src/test/resources/bugs/issue_23813.yaml.Written for commit 14e75a6. Summary will update on new commits. Review in cubic