Skip to content

Fix linting issues#869

Open
m-mohr wants to merge 1 commit intomasterfrom
fix-lint
Open

Fix linting issues#869
m-mohr wants to merge 1 commit intomasterfrom
fix-lint

Conversation

@m-mohr
Copy link
Member

@m-mohr m-mohr commented Mar 4, 2026

Just running it on master gives those changes, seems master is not clean currently. This complicates other PR such as #859.

Edit: Weird that tests fail after running only the linter.

Edit 2: Tests also fail on master for me...

@soxofaan
Copy link
Member

soxofaan commented Mar 4, 2026

what exactly do you mean with "linter" here?

the pre-commit rules as described at https://open-eo.github.io/openeo-python-client/development.html#pre-commit-for-basic-code-quality-checks ?

or linting/formating rules in your development environment?

@m-mohr
Copy link
Member Author

m-mohr commented Mar 4, 2026

I just ran pre-commit run --all-files and assumed that would run the stuff that gets shipped with this library?

@soxofaan
Copy link
Member

soxofaan commented Mar 4, 2026

FYI: the current pre-commit setup is intended to fixup just changed files and snippets

It is known that the whole repo is not yet fully in line with the rules defined there, because there was a lot of pre-existing code when those linting and formatting rules were added. And doing a big bang reformat of the whole repo will probably break all open pull requests and cause a lot of conflicts.

So at the moment it's intended to gradually improve the linting/formatting status of the repo, by just fixing things within the scope of each commit (e.g. the "darker" tool allows to just fixup formatting of lines that were touched, instead of doing full file reformatting).

@soxofaan
Copy link
Member

soxofaan commented Mar 4, 2026

also see #870 and #294

@m-mohr
Copy link
Member Author

m-mohr commented Mar 4, 2026

The changes in this PR seem to be pretty small for a full lint. Is this really so problematic?

Can also be closed of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants