Skip to content

Ogc 2725 saml2 login fur parlamentarier#2413

Merged
cyrillkuettel merged 7 commits intomasterfrom
ogc-2725-saml2-login-fur-parlamentarier
Mar 23, 2026
Merged

Ogc 2725 saml2 login fur parlamentarier#2413
cyrillkuettel merged 7 commits intomasterfrom
ogc-2725-saml2-login-fur-parlamentarier

Conversation

@cyrillkuettel
Copy link
Copy Markdown
Contributor

@cyrillkuettel cyrillkuettel commented Mar 19, 2026

Commit message

Pas: saml2 login for parliamentarians.

TYPE: Feature
LINK: OGC-2725

Checklist

  • I have performed a self-review of my code

@linear
Copy link
Copy Markdown

linear Bot commented Mar 19, 2026

@cyrillkuettel cyrillkuettel requested a review from Daverball March 19, 2026 15:13
Copy link
Copy Markdown
Member

@Daverball Daverball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I have just one small nitpick.

Comment thread src/onegov/pas/app.py Outdated
cyrillkuettel and others added 2 commits March 23, 2026 14:09
Co-authored-by: David Salvisberg <david.salvisberg@seantis.ch>
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 29.16667% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.31%. Comparing base (c690d7d) to head (3d2029e).
⚠️ Report is 6 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/onegov/pas/app.py 30.43% 16 Missing ⚠️
src/onegov/pas/collections/parliamentarian.py 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/onegov/pas/collections/parliamentarian.py 74.39% <0.00%> (-0.92%) ⬇️
src/onegov/pas/app.py 78.20% <30.43%> (-20.01%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c690d7d...3d2029e. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cyrillkuettel cyrillkuettel merged commit a6288c0 into master Mar 23, 2026
14 of 15 checks passed
@cyrillkuettel cyrillkuettel deleted the ogc-2725-saml2-login-fur-parlamentarier branch March 23, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants