moved extraposttxfilter hook call before finalise - NIT-4638

[mahdy-nasr]

Address linear issue NIT-4638.

Move extraPostTxFilter to trigger before statedb finalise.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.07%. Comparing base (976ea45) to head (45bf176).
⚠️ Report is 171 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4592      +/-   ##
==========================================
- Coverage   34.09%   34.07%   -0.03%     
==========================================
  Files         497      497              
  Lines       59155    59153       -2     
==========================================
- Hits        20169    20156      -13     
- Misses      35434    35438       +4     
- Partials     3552     3559       +7     

[github-actions]

❌ 9 Tests Failed:

Tests completed	Failed	Passed	Skipped
4743	9	4734	0

View the top 3 failed tests by shortest run time

TestAliasingFlaky

Stack Traces | -0.000s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [04-09|07:52:35.312] Persisted trie from memory database      nodes=118 flushnodes=0 size=14.16KiB flushsize=0.00B time="269.775µs" flushtime=0s gcnodes=0 gcsize=0.00B gctime="3.989µs"   livenodes=161 livesize=29.56KiB
INFO [04-09|07:52:35.312] Writing cached state to disk             block=8  hash=647c61..1652e1 root=60ed9f..597c24
INFO [04-09|07:52:35.312] Persisted trie from memory database      nodes=16  flushnodes=0 size=3.10KiB  flushsize=0.00B time="41.498µs"  flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s          livenodes=145 livesize=26.46KiB
INFO [04-09|07:52:35.312] Writing cached state to disk             block=1  hash=dd7a4c..39eaca root=c394bd..68b456
INFO [04-09|07:52:35.312] Persisted trie from memory database      nodes=24  flushnodes=0 size=4.58KiB  flushsize=0.00B time="263.303µs" flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s          livenodes=121 livesize=21.87KiB
INFO [04-09|07:52:35.312] Writing snapshot state to disk           root=77ae46..2fbcae
INFO [04-09|07:52:35.312] Persisted trie from memory database      nodes=0   flushnodes=0 size=0.00B    flushsize=0.00B time=501ns       flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s          livenodes=121 livesize=21.87KiB
ERROR[04-09|07:52:35.312] Dangling trie nodes after full cleanup
INFO [04-09|07:52:35.312] Blockchain stopped
INFO [04-09|07:52:35.313] Submitted transaction                    hash=0x57e601445b3627d121f392223c7ddaf5b9f69d47135ad2f827a6de00c52de5fa from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=5  recipient=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A value=1,000,000,000,000
INFO [04-09|07:52:35.313] Starting work on payload                 id=0x037ad4029288c79c
INFO [04-09|07:52:35.313] Updated payload                          id=0x037ad4029288c79c                      number=40 hash=edc301..ee41bd txs=1  withdrawals=0 gas=21000     fees=0.002081951642 root=afc354..d459c0 elapsed="240.942µs"
INFO [04-09|07:52:35.313] Ethereum protocol stopped
INFO [04-09|07:52:35.313] Stopping work on payload                 id=0x037ad4029288c79c                      reason=delivery
INFO [04-09|07:52:35.314] Transaction pool stopped
INFO [04-09|07:52:35.314] Persisting dirty state                   head=36 root=f03ab5..00e10a layers=36
INFO [04-09|07:52:35.314] Imported new potential chain segment     number=40 hash=edc301..ee41bd blocks=1  txs=1  mgas=0.021 elapsed="337.14µs"  mgasps=62.289   triediffs=199.00KiB triedirty=0.00B
INFO [04-09|07:52:35.314] Chain head was updated                   number=40 hash=edc301..ee41bd root=afc354..d459c0 elapsed="28.413µs"
INFO [04-09|07:52:35.314] Persisted dirty state to disk            size=173.06KiB elapsed="875.67µs"
INFO [04-09|07:52:35.315] Blockchain stopped

TestBatchPosterL1SurplusMatchesBatchGasFlaky

Stack Traces | 0.550s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
panic: runtime error: invalid memory address or nil pointer dereference [recovered, repanicked]
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x20f34d2]

goroutine 16 [running]:
testing.tRunner.func1.2({0x3866ac0, 0x62fd9b0})
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1872 +0x237
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1875 +0x35b
panic({0x3866ac0?, 0x62fd9b0?})
	/opt/hostedtoolcache/go/1.25.8/x64/src/runtime/panic.go:783 +0x132
github.com/offchainlabs/nitro/arbnode.(*InboxTracker).GetBatchCount(0x19c3f900?)
	/home/runner/work/nitro/nitro/arbnode/inbox_tracker.go:210 +0x12
github.com/offchainlabs/nitro/arbnode.(*InboxTracker).FindInboxBatchContainingMessage(0x0, 0x7)
	/home/runner/work/nitro/nitro/arbnode/inbox_tracker.go:225 +0x2f
github.com/offchainlabs/nitro/system_tests.TestBatchPosterL1SurplusMatchesBatchGasFlaky(0xc000481500)
	/home/runner/work/nitro/nitro/system_tests/batch_poster_test.go:839 +0x725
testing.tRunner(0xc000481500, 0x42425f8)
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1934 +0xea
created by testing.(*T).Run in goroutine 1
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1997 +0x465

TestRetryableFilteringStylusDelayedSandwichRollback

Stack Traces | 4.220s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [04-09|07:56:25.225] Persisted trie from memory database      nodes=25  flushnodes=0 size=4.62KiB   flushsize=0.00B time="293.372µs" flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s         livenodes=126 livesize=23.58KiB
INFO [04-09|07:56:25.225] Writing snapshot state to disk           root=7b58a7..e6d44e
INFO [04-09|07:56:25.225] Persisted trie from memory database      nodes=0   flushnodes=0 size=0.00B     flushsize=0.00B time="3.276µs"   flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s         livenodes=126 livesize=23.58KiB
ERROR[04-09|07:56:25.225] Dangling trie nodes after full cleanup
INFO [04-09|07:56:25.225] Submitted transaction                    hash=0xf8fc2bdcf145cb5cee56fcf1ef0ef12ab0af6ea135e7f70716bd41c9ba3a48b6 from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=79  recipient=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A value=1,000,000,000,000
INFO [04-09|07:56:25.225] Blockchain stopped
INFO [04-09|07:56:25.225] New Key                                  name=User2                Address=0x0C709F340F0BB2e361229e345B7e26999d0969Ab
INFO [04-09|07:56:25.225] Updated payload                          id=0x034749fbf34074d3 number=126 hash=566730..f75497 txs=1  withdrawals=0 gas=21000      fees=0.002099999809 root=8a5fda..c4e16f elapsed="760.505µs"
INFO [04-09|07:56:25.225] New Key                                  name=Beneficiary          Address=0xf0ee71e56D4fA13648c86665D45799A1a81b046B
INFO [04-09|07:56:25.225] Submitted transaction                    hash=0xbe676706f2ac01c976192322565d9b3a5f100e01b074acb1e8a9a9bcd8e9835d from=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 nonce=0   recipient=0x00000000000000000000000000000000000000ff value=0
INFO [04-09|07:56:25.225] New Key                                  name=Burn                 Address=0x18E3868225c098D94f9e9A7Aba3f5ADD654397f0
INFO [04-09|07:56:25.225] Persisted dirty state to disk            size=621.23KiB elapsed=12.245ms
INFO [04-09|07:56:25.226] Blockchain stopped
INFO [04-09|07:56:25.226] Stopping work on payload                 id=0x034749fbf34074d3 reason=delivery
INFO [04-09|07:56:25.226] Starting work on payload                 id=0x037dd94fb60b3d0b
INFO [04-09|07:56:25.227] Imported new potential chain segment     number=126 hash=566730..f75497 blocks=1  txs=1  mgas=0.021  elapsed=1.295ms      mgasps=16.204   triediffs=549.22KiB triedirty=0.00B
INFO [04-09|07:56:25.227] Ethereum protocol stopped
INFO [04-09|07:56:25.227] Chain head was updated                   number=126 hash=566730..f75497 root=8a5fda..c4e16f elapsed="97.834µs"
INFO [04-09|07:56:25.227] Transaction pool stopped
--- FAIL: TestRetryableFilteringStylusDelayedSandwichRollback (4.22s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov