Improve error handling, robustness, and resource cleanup across testnode#185
Open
joshuacolvin0 wants to merge 1 commit intonit-4763-adjust-testnode-docker-to-improve-resource-releasefrom
Open
Conversation
- Fix WebSocket provider and Redis/S3 connection leaks on error paths - Add timeouts to bridgeFunds, bridgeNativeToken, waitForSync polling loops - Replace fragile tail|tr output parsing with validated capture helpers - Replace sleep 45 with deterministic wait_for_chain_progress - Add Docker healthchecks and service_healthy dependency conditions - Fix l3node and validator sharing the same data volume - Fix minio healthcheck using curl (not in image); use mc ready local - Remove incorrect rollupcreator dependency on sequencer - Fix auctioneer healthcheck checking /data which is never written - Enable set -euo pipefail and add background PID cleanup trap - Replace sed-based JSON rewriting with atomic jq + mv - Fix missing shift for --dev-contracts flag - Fix unanchored regexes and order-dependent flag validation - Add argument validation for --batchposters, --redundantsequencers, --l3-fee-token-decimals - Replace process.exit(1) with throw in stress.ts - Fix yargs boolean type for l3 flag - Deduplicate readJsonFile pattern into shared helper - Fix echo saying "L2" during L1 Reference DA deployment Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com