Skip to content

Improve error handling, robustness, and resource cleanup across testnode#185

Open
joshuacolvin0 wants to merge 1 commit intonit-4763-adjust-testnode-docker-to-improve-resource-releasefrom
testnode-hardening
Open

Improve error handling, robustness, and resource cleanup across testnode#185
joshuacolvin0 wants to merge 1 commit intonit-4763-adjust-testnode-docker-to-improve-resource-releasefrom
testnode-hardening

Conversation

@joshuacolvin0
Copy link
Copy Markdown
Member

  • Fix WebSocket provider and Redis/S3 connection leaks on error paths
  • Add timeouts to bridgeFunds, bridgeNativeToken, waitForSync polling loops
  • Replace fragile tail|tr output parsing with validated capture helpers
  • Replace sleep 45 with deterministic wait_for_chain_progress
  • Add Docker healthchecks and service_healthy dependency conditions
  • Fix l3node and validator sharing the same data volume
  • Fix minio healthcheck using curl (not in image); use mc ready local
  • Remove incorrect rollupcreator dependency on sequencer
  • Fix auctioneer healthcheck checking /data which is never written
  • Enable set -euo pipefail and add background PID cleanup trap
  • Replace sed-based JSON rewriting with atomic jq + mv
  • Fix missing shift for --dev-contracts flag
  • Fix unanchored regexes and order-dependent flag validation
  • Add argument validation for --batchposters, --redundantsequencers, --l3-fee-token-decimals
  • Replace process.exit(1) with throw in stress.ts
  • Fix yargs boolean type for l3 flag
  • Deduplicate readJsonFile pattern into shared helper
  • Fix echo saying "L2" during L1 Reference DA deployment

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

- Fix WebSocket provider and Redis/S3 connection leaks on error paths
- Add timeouts to bridgeFunds, bridgeNativeToken, waitForSync polling loops
- Replace fragile tail|tr output parsing with validated capture helpers
- Replace sleep 45 with deterministic wait_for_chain_progress
- Add Docker healthchecks and service_healthy dependency conditions
- Fix l3node and validator sharing the same data volume
- Fix minio healthcheck using curl (not in image); use mc ready local
- Remove incorrect rollupcreator dependency on sequencer
- Fix auctioneer healthcheck checking /data which is never written
- Enable set -euo pipefail and add background PID cleanup trap
- Replace sed-based JSON rewriting with atomic jq + mv
- Fix missing shift for --dev-contracts flag
- Fix unanchored regexes and order-dependent flag validation
- Add argument validation for --batchposters, --redundantsequencers, --l3-fee-token-decimals
- Replace process.exit(1) with throw in stress.ts
- Fix yargs boolean type for l3 flag
- Deduplicate readJsonFile pattern into shared helper
- Fix echo saying "L2" during L1 Reference DA deployment

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants