feat: add nitro-contracts-version dimension to CI runtime images#1
Merged
feat: add nitro-contracts-version dimension to CI runtime images#1
Conversation
Adds a `nitro-contracts-version` input to the composite action so consumers
can select which nitro-contracts version (v2.1, v3.2) the Docker image was
built against. Image tags now include an `nc` prefix component:
`{version}-nc{major.minor}-{variant}` (e.g. v0.2.0-nc3.2-l3-custom-18).
The action exports ARBITRUM_TESTNODE_NITRO_CONTRACTS_VERSION and
INTEGRATION_TEST_NITRO_CONTRACTS_BRANCH env vars for downstream tests.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nitro-contracts-versioninput to the composite action (default:v3.2, options:v2.1,v3.2){version}-{variant}to{version}-nc{major.minor}-{variant}(e.g.v0.2.0-nc3.2-l3-custom-18)ARBITRUM_TESTNODE_NITRO_CONTRACTS_VERSIONandINTEGRATION_TEST_NITRO_CONTRACTS_BRANCHenv varsnitro-contracts-versioninput andnctag componentnitroContractsVersionto snapshot manifest and runtime metadataThis enables consumers like
arbitrum-orbit-sdkto test against multiple nitro-contracts versions using the same action.Files changed
scripts/action/lib.mjs—CONTRACTS_VERSIONSmap,normalizeContractsVersion(), updatedbuildImageRef()andbuildActionState()action.yml— new input/output, wired through resolve and run stepsscripts/action/resolve.mjs/run.mjs— thread contracts version, export env varsscripts/ci/prepare-runtime-context.mjs—--nitro-contracts-versionarg, metadata.json.github/workflows/release-ci-runtime.yml— new input, tag step, updated image tag.github/workflows/test-action.yml— passesnitro-contracts-version: v3.2src/snapshot.ts— optionalnitroContractsVersionon manifesttest/ci-action.test.ts— updated + 2 new teststest/ci-runtime-context.test.ts— metadata assertionTest plan
ci-action.test.ts— 10 tests pass (contracts version in image ref, defaults, validation)ci-runtime-context.test.ts— metadata includesnitroContractsVersiontest-action.ymlworkflow passes on PR (builds local image withnc3.2tag)