use compat version of SqlServer PSModule for SSIS deploy ispac from package#1658
Draft
bcullman wants to merge 1 commit intoOctopusDeploy:masterfrom
Draft
Conversation
|
Start Hyponome locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The documentation for Deploy ispac SSIS project from a Package parameter correctly points out that newer versions of the SqlServer PSModule this step template relies on no longer include the necessary assemblies to interface with SSIS, and so a pinned version (21.1.18256) is noted.
The fix here is to only use a already installed SqlServer PSModule if it is compatible with SSIS (21.1.18256) or below). Otherwise, install a temp version of 21.1.18256.
Results
Before
snipped of Octo Log output when SqlServer PSModule (22.3.0) was found and used)
After
snipped of Octo Log output when SqlServer PSModule (22.3.0) was found, ignored and temp version 21.1.18256 was used instead:
Pre-requisites
[NA] Id should be a GUID that is not 00000000-0000-0000-0000-000000000000
NOTE If you are modifying an existing step template, please make sure that you do not modify the Id property (updating the Id will break the Library sync functionality in Octopus).
[NA] Version should be incremented, otherwise the integration with Octopus won't update the step template correctly
[NA] Parameter names should not start with $
[NA] Step template parameter names (the ones declared in the JSON, not the script body) should be prefixed with a namespace so that they are less likely to clash with other user-defined variables in Octopus (see OctopusDeploy/Issues#2126). For example, use an abbreviated name of the step template or the category of the step template).
[NA] LastModifiedBy field must be present, and (optionally) updated with the correct author
[✔] The best practices documented here have been applied
[NA] If a new Category has been created:
[NA] An image with the name {categoryname}.png must be present under the step-templates/logos folder
[NA] The switch in the humanize function in gulpfile.babel.js must have a case statement corresponding to it
Fixes #1657