Add ssh credentials for git#1901
Conversation
# Conflicts: # source/Calamari.Tests/ArgoCD/Git/GitHttpSmartSubTransportTests.cs
# Conflicts: # source/Calamari.Tests/ArgoCD/Git/RepositoryWrapperTest.cs
| ArgoCDApplicationDto[] Applications, | ||
| GitCredentialDto[] Credentials, | ||
| // Nullable for backwards compatibility | ||
| GitCredentialSshKeyDto[]? SshCredentials); |
There was a problem hiding this comment.
With shared contracts, I figure a new Octopus server might be talking to an old calamari?
Unsure if this is truely needed to be nullable
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
Adds support for passing through ssh git credentials down to LibGit2Sharp
Will update the LibGit2Sharp version to a real release before merging.
Server side change: https://github.com/OctopusDeploy/OctopusDeploy/pull/42731
Closes MD-1680