fix: ensure image references contain the full image and not just the image tag#1896
Merged
Conversation
rain-on
approved these changes
Apr 21, 2026
Contributor
rain-on
left a comment
rain-on
left a comment
There was a problem hiding this comment.
We really should use types but this looks good
| if (valueToUpdate == newImageTag.ContainerReference.Tag) | ||
| { | ||
| alreadyUpToDate.Add(newImageTag.ContainerReference.Tag); | ||
| alreadyUpToDate.Add(newImageTag.ContainerReference.FriendlyName()); |
Contributor
There was a problem hiding this comment.
Wondering if the imagesToUpdate and alreadyUpToDate should be lists of ContainerImageReference rather than string lists - that way we'd have better type protections.
Otherwise, the fix looks good.
Contributor
There was a problem hiding this comment.
Then are you thinking ImageReplacementResult will reference ContainerImageReference instead of strings @rain-on ?
That can be done in a separate PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was adding tests for
HelmValuesImageReplaceStepVariablesclass in this pr: #1894 and I think I found a bug. I've extracted the tests and the fix for the bug into this PR for separate review.The test failure looks like:
These tests fail before fix is applied:
