[18.0][FIX] edi_core_oca: fix record rule#251
Merged
OCA-git-bot merged 1 commit intoOCA:18.0from Apr 16, 2026
Merged
Conversation
Contributor
simahawk
requested changes
Mar 26, 2026
Exchange Record's ``res_id`` is a ``Many2onReference`` field, which internally converts False-ish values to 0 before storing them to the cache and the DB.
The rule's domain old leaf ``('res_id', '=', False)`` was instead converted to a SQL query clause ``WHERE "edi_exchange_record.res_id" IS NULL``.
Since all ``edi_exchange_record`` rows contain a non-negative integer in the ``res_id`` column, the rule old domain leaf always failed to fetch any record.
Changing the leaf to ``('res_id', '=', 0)`` fixes the issue, making such Exchange Records visible again for internal users.
SilvioC2C
force-pushed
the
18.0-fix-exc_record_rule
branch
from
38b0b28 to
4e98519
Compare
simahawk
approved these changes
Apr 16, 2026
Contributor
simahawk
left a comment
simahawk
left a comment
There was a problem hiding this comment.
@JordiMForgeFlow could you pls have a look at this?
JordiMForgeFlow
approved these changes
Apr 16, 2026
Contributor
JordiMForgeFlow
left a comment
JordiMForgeFlow
left a comment
There was a problem hiding this comment.
it was always a bit annoying when you had these cases, thanks for the fix!
Contributor
|
/ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
@SilvioC2C can you fwd port to 19? |
Contributor
|
Congratulations, your PR was merged at 8365818. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exchange Record's
res_idis aMany2onReferencefield, which internally converts False-ish values to 0 before storing them to the cache and the DB.The rule's domain old leaf
('res_id', '=', False)was instead converted to a SQL query clauseWHERE "edi_exchange_record.res_id" IS NULL.Since all
edi_exchange_recordrows contain a non-negative integer in theres_idcolumn, the rule old domain leaf always failed to fetch any record.Changing the leaf to
('res_id', '=', 0)fixes the issue, making such Exchange Records visible again for internal users.