[skyrl-train] Flip grpo_norm_by_std default to false#1443
Open
taivu1998 wants to merge 2 commits intoNovaSky-AI:mainfrom
Open
[skyrl-train] Flip grpo_norm_by_std default to false#1443taivu1998 wants to merge 2 commits intoNovaSky-AI:mainfrom
taivu1998 wants to merge 2 commits intoNovaSky-AI:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the default value of grpo_norm_by_std from true to false across the codebase, including the AlgorithmConfig class, PPO utility functions, and the base YAML configuration. The documentation has been updated to reflect this change and provide instructions for recovering the previous behavior. Additionally, new unit tests have been added to verify the new default setting and ensure that explicit overrides are respected. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the default value of
trainer.algorithm.grpo_norm_by_stdfromtruetofalseacross the canonical config and utility surfaces.It keeps the existing trainer plumbing intact, aligns the config docs with the new default, and adds regression coverage so the repo now explicitly protects:
Closes #869.
What changed
AlgorithmConfig.grpo_norm_by_stdtoFalsefalseppo_utils.pytoFalsegrpo_norm_by_std=Truefrom shared test helpersfalsetruefalseWhy this approach
The runtime already forwarded
self.cfg.trainer.algorithm.grpo_norm_by_stdcorrectly, so this change stays intentionally small and focused on the default surfaces rather than rewriting trainer logic.It also avoids broad example churn: examples that already pin
falseremain explicit, while other flows inherit the new default naturally.Testing