#4013 fix all change request table crash#4103
Open
Conversation
Steph375
requested changes
Mar 31, 2026
Contributor
Steph375
left a comment
Steph375
left a comment
There was a problem hiding this comment.
This looks good to me just one small change! Great job!
| filterValues = JSON.parse(localStorage.getItem('changeRequestsTableFilter') ?? defaultFilter); | ||
| } catch { | ||
| localStorage.removeItem('changeRequestsTableFilter'); | ||
| filterValues = JSON.parse(defaultFilter); |
Contributor
There was a problem hiding this comment.
One edge case: if localStorage contains valid JSON but not the expected shape, this will still succeed and give us undefined values in initialState. Might be worth validating the parsed object before using it.
Contributor
Author
|
Added checks to enforce valid JSON structure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When an item is removed from localStorage and it becomes undefined, we still access it using localStorage.setIterm. This is the main cause of the issues. I fixed this via adding a condition to check against undefined and added a try and catch statement to JSON.parse to catch any corrupted values in localStorage.
Test Cases
Closes #4013