Skip to content

Feature/global car filtering#4028

Merged
chpy04 merged 100 commits intodevelopfrom
feature/global-car-filtering
Apr 9, 2026
Merged

Feature/global car filtering#4028
chpy04 merged 100 commits intodevelopfrom
feature/global-car-filtering

Conversation

@cielbellerose
Copy link
Copy Markdown
Contributor

@cielbellerose cielbellerose commented Mar 10, 2026

Changes

Pages updated for filtering included: Home, Gantt, Projects, Change Requests, Finance.
Pages excluded from global filtering: Teams, Statistics, Calendar, Restrospective.

  • Add global car filter in sidebar.
  • Add override capabilities for specific pages to override global filter.
  • Add middleware to pass in car selection.
  • Add backend filtering for endpoints linked to pages that should be filtered.

Notes

Two features follow slightly different formats than the rest of the website for unique reasons.

  • Gantt Chart overrides carId header to always capture all data; does front-end filtering; necessary due to local multi-car filtering.
  • Finance pages take in global filter to display choice in page dropdowns; always flows choice back into the override.

Side changes that I believe were important to note.

  • Moved seed data from Fergus to NER-25 to make tests simpler, since NER-25 is the most recent car.
  • Fixed dropdowns to exclude guests (side change asked to be included in PR).

Compared to the ticket, some implementations are slightly different.

  • Currently we default the car in the dropdown to the last globally selected car or all cars if not possible, however, the ticket indicates the default should always be the current car for the year.
  • Currently the local filter on a page is preserved until the website is reloaded or until the next session, however, the ticket indicates the local filter should reset to global when the user navigates away from the page.

Screenshots

image

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #3629

superhvarn and others added 30 commits October 15, 2025 15:54
include optional car param for getAllWorkPackages and getManyWorkPackages
enable support of optional car param with getAllWorkPackages and getManyWorkPackages
add optional car param to more methods
make sure optional car param is used
include checks for optional car param
…llProjects-endpoints-car-filtering

#3950 get projects endpoints car filtering
Add backend support for global car filtering
update controller for middleware, fix bug due to type change in service
@rbessin rbessin self-assigned this Mar 31, 2026
@rbessin rbessin marked this pull request as ready for review April 2, 2026 18:46
@rbessin rbessin requested a review from chpy04 April 2, 2026 18:46
Copy link
Copy Markdown
Contributor

@chpy04 chpy04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good work, main thing is dedicated all cars handling instead of implicit with undefined. Also in terms of UI, on the selector:

Image

Can we

  • add some spacing on to of the "Working with" so its not so close to the top of the screen
  • Make the car options go all the way to the right below the sidebar arrow instead of getting horizontally cut off even when there is nothing to the right of them

@rbessin rbessin requested a review from chpy04 April 7, 2026 14:25
Copy link
Copy Markdown
Contributor

@chpy04 chpy04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bangggggggggggggggg

@chpy04 chpy04 merged commit c4cf1eb into develop Apr 9, 2026
5 checks passed
@chpy04 chpy04 deleted the feature/global-car-filtering branch April 9, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Maintenance] - Global & Finance Filtering

7 participants