Notification log for triggered rule events#556
Merged
Conversation
bracyw
commented
Mar 30, 2026
.claude/settings.json
Outdated
| @@ -0,0 +1 @@ | |||
| /Users/wyattbracy/Desktop/ner/app_software/Argos/Argos-worktrees/.claude/settings.json No newline at end of file | |||
Collaborator
Author
There was a problem hiding this comment.
Claude folder should be ignored
| additionalStyles="fontSize: 36px" | ||
| /> | ||
| <messages-per-second /> | ||
| <div |
Collaborator
Author
There was a problem hiding this comment.
This should be made it's own component and abstracted to be able to be used again.
| { | ||
| id: appRoutes.notificationLogRoute(), | ||
| label: 'Notification Log', | ||
| onClick: () => this.navigateTo(appRoutes.notificationLogRoute()), |
Collaborator
Author
There was a problem hiding this comment.
We should create another ticket to generalize the Notification Center to have different sections and be customizable.
| </div> | ||
| } @else { | ||
| @for (entry of notificationLogService.recentNotifications(); track entry.id) { | ||
| <div class="notification-item" [class.unread]="!entry.read"> |
Collaborator
Author
There was a problem hiding this comment.
We should use a primeng component for this if possible. Oriented towards notifications or data of this type.
| }); | ||
| } | ||
|
|
||
| markAllRead(): void { |
Collaborator
Author
There was a problem hiding this comment.
Review if this is needed yet and add docs on how it is currently used
suryatho
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Captures rule_notify socket events on the frontend and surfaces them across the nav, Rules page, and a dedicated log page — all backed by a single signal-based NotificationLogService (session-only, 500-entry cap).
Notes
Test Cases
Screenshots
screenshot pending
Checklist
Closes #544