fixed overflow error in axonarawio when loading long recordings#1829
Merged
alejoe91 merged 1 commit intoNeuralEnsemble:masterfrom Apr 1, 2026
Merged
Conversation
alejoe91
approved these changes
Mar 29, 2026
zm711
approved these changes
Mar 31, 2026
Contributor
zm711
left a comment
zm711
left a comment
There was a problem hiding this comment.
This looks fine to me too. I feel like we did a bunch of overflow squashing a while back, but I'm sure we are still missing a bunch. Thanks for the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed lines 389 and 405 in axonarawio.py so that sample indices are cast as np.uint64