Include https-dns-proxy with safe defaults#1691
Merged
gsanchietti merged 1 commit intoMay 26, 2026
Merged
Conversation
Bundle https-dns-proxy in the image and default\ndnsmasq_config_update to '-'. This keeps the package available\nout of the box without changing dnsmasq or starting the service\nuntil an administrator enables it.\n\nTreat dnsmasq_config_update='-' as the disabled state so image\nupgrades can keep the default-off behavior. This can disable the\nservice again after an upgrade if dnsmasq integration remains\ndisabled, which is acceptable for now because configuration is\nsupported only from the command line.\n\nAssisted-by: Copilot:gpt-5.4
Tbaile
approved these changes
May 26, 2026
gsanchietti
merged commit d853f7e
into
NethServer:nethsecurity-8.8
1 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https-dns-proxyin the imagednsmasq_config_updateto-Related issue
Refs: #1638
How to test
/etc/config/https-dns-proxyexists and defaultsdnsmasq_config_updateto-./etc/init.d/https-dns-proxy enabledreturns false after first boot.uci set https-dns-proxy.config.dnsmasq_config_update='*', commit the config, enable the service, and start it.Dependencies
Known limitation
If
dnsmasq_config_updateremains-, the first-boot defaults script can disablehttps-dns-proxyagain after an image upgrade. Right now this should not be a practical problem because configuration is supported only from the command line.