Fix #675#680
Merged
Merged
Conversation
…rror for large files Fixes #675. The C int type used for the loop variable in get_chunks overflows for data larger than ~2GB. Py_ssize_t matches Python's indexing size and handles arbitrarily large buffers correctly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
cdef int max_age in cookies.pxd/.pyx overflows for max-age values > 2^31. Same class of bug as the scribe.pyx get_chunks overflow (issue #675). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…_age param type - scribe.pyx: cdef int MAX_RESPONSE_CHUNK_SIZE is not exported as a Python name from .so files; expose as Python-level constant and use private C alias internally - cookies.pyx: Cookie.__init__ param was still typed as C int, causing OverflowError before assignment to the long long field; changed param to long long Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.