exec::repeat_until et al.: Dependent Child Sender Support#1879
Merged
ericniebler merged 8 commits intoNVIDIA:mainfrom Mar 3, 2026
Merged
exec::repeat_until et al.: Dependent Child Sender Support#1879ericniebler merged 8 commits intoNVIDIA:mainfrom
ericniebler merged 8 commits intoNVIDIA:mainfrom
Conversation
The TODO eliminated by this commit not only meant that exec:: repeat_until et al. previously didn't the usual constant evaluation techniques to report errors, it also meant that a hard compile error (rather than a return type indicating that the sender is dependent) resulted if: - The child sender was dependent, and - An attempt was made to determine the completion signatures of the parent without an environment Updated so exec::repeat_until et al. now properly report that they are dependent if their child is dependent.
ericniebler
reviewed
Feb 21, 2026
Collaborator
|
/ok to test 62c7d22 |
Collaborator
|
/ok to test 3d97de3 |
Collaborator
|
/ok to test 03d29fd |
Collaborator
|
/ok to test 299ba24 |
Collaborator
|
/ok to test 5eda5dc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TODO eliminated by this commit not only meant that exec::repeat_until et al. previously didn't the usual constant evaluation techniques to report errors, it also meant that a hard compile error (rather than a return type indicating that the sender is dependent) resulted if:
Updated so exec::repeat_until et al. now properly report that they are dependent if their child is dependent.