Skip to content

Add combined-workflow and from-checkpoint diffusion tests#1569

Merged
CharlelieLrt merged 3 commits intoNVIDIA:mainfrom
CharlelieLrt:test/diffusion-combined-workflow-from-checkpoint
Apr 16, 2026
Merged

Add combined-workflow and from-checkpoint diffusion tests#1569
CharlelieLrt merged 3 commits intoNVIDIA:mainfrom
CharlelieLrt:test/diffusion-combined-workflow-from-checkpoint

Conversation

@CharlelieLrt
Copy link
Copy Markdown
Collaborator

PhysicsNeMo Pull Request

Description

Checklist

Dependencies

Review Process

All PRs are reviewed by the PhysicsNeMo team before merging.

Depending on which files are changed, GitHub may automatically assign a maintainer for review.

We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.

AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 15, 2026

Greptile Summary

This PR adds combined-workflow tests that exercise the realistic SDA recipe — EDMPreconditioner(backbone) wrapped inside MultiDiffusionModel2D paired with a consistently-parameterized EDMNoiseScheduler — and adds from-checkpoint variants for patch_x and fuse in the existing TestNonRegression class. Reference .pth and .mdlus files are committed alongside the new tests. The changes are purely additive test infrastructure with no modifications to production code.

Important Files Changed

Filename Overview
test/diffusion/test_losses.py Adds two new parametrized test classes (TestMSEDSMLossWithPreconditioner and TestWeightedMSEDSMLossWithPreconditioner) exercising the full EDMPreconditioner + EDMNoiseScheduler + loss pipeline; ref_file is redundantly assigned in both if/else branches.
test/diffusion/test_multi_diffusion_losses.py Adds TestMSEDSMLossWithPreconditionedInnerModel and TestWeightedMSEDSMLossWithPreconditionedInnerModel for the realistic wrapping order (EDMPreconditioner inside MultiDiffusionModel2D); training loops are duplicated inline rather than using the existing _run_training_loop helper.
test/diffusion/test_multi_diffusion_models.py Adds test_patch_x_from_checkpoint and test_fuse_from_checkpoint to TestNonRegression, and a new TestWithPreconditionedInnerModel class for EDMPreconditioner as the inner model; design is consistent with the existing test patterns.

Reviews (1): Last reviewed commit: "Add combined-workflow and from-checkpoin..." | Re-trigger Greptile

Comment thread test/diffusion/test_losses.py Outdated
Comment thread test/diffusion/test_multi_diffusion_losses.py
Copy link
Copy Markdown
Collaborator

@pzharrington pzharrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New tests look good!

Addresses Greptile review comment on PR NVIDIA#1569.

Signed-off-by: Charlelie Laurent <claurent@nvidia.com>
@CharlelieLrt CharlelieLrt force-pushed the test/diffusion-combined-workflow-from-checkpoint branch from 4e6fcb8 to d0166c2 Compare April 16, 2026 19:00
@CharlelieLrt CharlelieLrt enabled auto-merge April 16, 2026 19:04
@CharlelieLrt
Copy link
Copy Markdown
Collaborator Author

/blossom-ci

1 similar comment
@CharlelieLrt
Copy link
Copy Markdown
Collaborator Author

/blossom-ci

@CharlelieLrt CharlelieLrt added this pull request to the merge queue Apr 16, 2026
Merged via the queue into NVIDIA:main with commit c1b99f1 Apr 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants