Adds DomainMesh improvements, docs, and bugfixes#1558
Open
peterdsharpe wants to merge 27 commits intoNVIDIA:mainfrom
Open
Adds DomainMesh improvements, docs, and bugfixes#1558peterdsharpe wants to merge 27 commits intoNVIDIA:mainfrom
DomainMesh improvements, docs, and bugfixes#1558peterdsharpe wants to merge 27 commits intoNVIDIA:mainfrom
Conversation
…at allows selective application of functions to interior and boundary meshes. Update related tests to validate the new functionality and ensure proper behavior with global data preservation.
…ing existing plotters. This allows overlaying multiple meshes on the same scene.
…ns to support both matplotlib and PyVista backends, allowing for overlaying multiple meshes on the same scene.
…uce geometry-only meshes, improving check_boundary_watertight to include a cleaning step. Documentation for these methods has also been added or updated.
…streamline boundary mesh representation, enhancing readability and consistency in displayed mesh information.
…t sets This new function utilizes KNN to find and return matched indices of source and target points within a specified tolerance, enhancing the sampling capabilities of the mesh module.
Contributor
Greptile SummaryThis PR adds Important Files Changed
Reviews (1): Last reviewed commit: "formatting" | Re-trigger Greptile |
… and improve formatting of mesh data representation, enhancing clarity and consistency in the tutorial outputs.
This commit introduces a new test to ensure that passing a PyVista Plotter to the mesh draw method with the matplotlib backend raises the appropriate ValueError. This enhances the robustness of the visualization module by validating error handling for unsupported backends.
This commit adds validation checks to ensure that the 'ax' parameter in the draw_mesh_matplotlib function is a valid matplotlib Axes object, and the 'plotter' parameter in the draw_mesh_pyvista function is a valid PyVista Plotter object. Appropriate ValueErrors are raised for invalid types, improving robustness in backend handling.
…a backends This commit enhances the docstrings for the draw_mesh_matplotlib and draw_mesh_pyvista functions, clarifying the purpose of the 'ax' and 'plotter' parameters, respectively. The updates specify that these parameters can be used to overlay multiple meshes on the same axes or scene, improving the usability and understanding of the functions.
Collaborator
Author
|
/blossom-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
Contains a bunch of small improvements to
DomainMesh, such as:DomainMesh.draw()to mirrorMesh.draw()with multi-mesh support.DomainMesh.n_boundaries, where we were incorrectly returning the `TensorDictDomainMesh.check_boundary_watertight()bugfix by deduplicating vertices before watertightness checkChecklist
Dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.