Disable running notebooks while building docs#980
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdded an Sphinx configuration entry Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/cuopt/source/conf.py (1)
94-99: Consider cleaning up unused nbsphinx configuration.Line 94 configures
nbsphinx_execute = "never", but thenbsphinxextension is not present in theextensionslist (lines 61-78). Since myst_nb is the actual notebook processor being used (line 75), this configuration has no effect and could create confusion.Consider removing line 94 to eliminate the unused configuration, or add a comment explaining if it's intentionally kept for backward compatibility.
♻️ Proposed cleanup
-nbsphinx_execute = "never" -ipython_mplbackend = "str" - # GPU routing example: execution during Sphinx can fail when CUDA/CuPy don't match the # docs env. The notebook sets mystnb.execution_mode=off and ships checked-in outputs. nb_execution_excludepatterns = ["cuopt-python/routing/routing-example.ipynb"] + +ipython_mplbackend = "str"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/cuopt/source/conf.py` around lines 94 - 99, The nbsphinx-specific setting nbsphinx_execute = "never" is unused because the Sphinx extensions list does not include "nbsphinx" and the project uses myst_nb (myst_nb in the extensions list); either remove the nbsphinx_execute line or add a clarifying comment above it indicating it’s intentionally retained for backward compatibility; update conf.py by deleting the nbsphinx_execute assignment (preferred) or adding a one-line comment referencing nbsphinx_execute and why it’s kept, and ensure any related nb_execution_excludepatterns or other nbsphinx settings are reviewed for relevance to myst_nb.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/cuopt/source/conf.py`:
- Around line 97-99: The comment above nb_execution_excludepatterns is
inaccurate about the notebook metadata claiming mystnb.execution_mode=off;
either remove or correct that statement in the comment and optionally set the
notebook metadata to execution_mode=off if you want the metadata to reflect the
intent. Update the comment lines near nb_execution_excludepatterns (referencing
nb_execution_excludepatterns and the notebook path
"cuopt-python/routing/routing-example.ipynb") to state that the notebook is
excluded from execution via nb_execution_excludepatterns, or modify the notebook
metadata to set execution_mode=off and then update the comment to reflect that
change.
---
Nitpick comments:
In `@docs/cuopt/source/conf.py`:
- Around line 94-99: The nbsphinx-specific setting nbsphinx_execute = "never" is
unused because the Sphinx extensions list does not include "nbsphinx" and the
project uses myst_nb (myst_nb in the extensions list); either remove the
nbsphinx_execute line or add a clarifying comment above it indicating it’s
intentionally retained for backward compatibility; update conf.py by deleting
the nbsphinx_execute assignment (preferred) or adding a one-line comment
referencing nbsphinx_execute and why it’s kept, and ensure any related
nb_execution_excludepatterns or other nbsphinx settings are reviewed for
relevance to myst_nb.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6768dbfc-aa59-4513-a2d9-107cb6e09d25
📒 Files selected for processing (1)
docs/cuopt/source/conf.py
|
/merge |
|
/merge |
cbec0e9
into
NVIDIA:release/26.04
Description
Disable running notebooks which are added examples while building docs
Checklist