feat(kubernetes): support driver config passthrough#1744
Open
elezar wants to merge 6 commits into
Open
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-1744.docs.buildwithfern.com/openshell |
drew
reviewed
Jun 5, 2026
Collaborator
drew
left a comment
drew
left a comment
There was a problem hiding this comment.
This looks really good to me. I say we ship it and then add podman/docker volume configs, and gpu configs.
Once those are in maybe we can work on config validation and more concretely defining schemas that can be validated by drivers.
Comment on lines
+98
to
+102
| struct KubernetesPodDriverConfig { | ||
| node_selector: BTreeMap<String, String>, | ||
| tolerations: Vec<serde_json::Value>, | ||
| priority_class_name: String, | ||
| } |
Collaborator
There was a problem hiding this comment.
Can we also add runtime_class_name here
Member
Author
There was a problem hiding this comment.
Yes. I made a note of this after the discussions in the community slack yesterday. Let me add it.
elezar
force-pushed
the
poc/kubernetes-driver-config-1589
branch
from
f99337f to
7c6bff6
Compare
elezar
changed the title
elezar
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
poc/kubernetes-driver-config-1589
branch
from
4e4ed33 to
ce91dfe
Compare
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
poc/kubernetes-driver-config-1589
branch
from
ce91dfe to
5189f78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the driver_config path end to end: CLI raw JSON, gateway driver-key selection, and Kubernetes driver-local typed config consumption. The Kubernetes driver now supports pod scheduling fields, agent container resources, and pod.runtime_class_name mapped to PodSpec runtimeClassName.
The typed SandboxTemplate runtime_class_name remains highest precedence. Kubernetes driver_config pod.runtime_class_name overrides the gateway default_runtime_class_name when the typed template field is absent.
Related Issue
Discussion POC for #1589.
Related to #1492.
Does not close either reference.
Changes
Testing
Checklist