Dkorzekwa/any model other models#1007
Dkorzekwa/any model other models#1007danielkorzekwa wants to merge 5 commits intodkorzekwa/mip_and_realize_modelsfrom
Conversation
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
danielkorzekwa
requested review from
kevalmorabia97
and removed request for
a team
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (3)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Why do we store all these configs instead of directly reading from HF using config = AutoConfig.from_pretrained("Qwen/Qwen3-8B")?
There was a problem hiding this comment.
To make sure we always use the same version for the test. I will add your suggestion to TODO so we will discuss it.
There was a problem hiding this comment.
Can we define one or more common yamls for all model tests and only define overwrites in one separate per-model yaml to avoid so many duplications and keep things simple?
There was a problem hiding this comment.
We dont want to maintain copies of all these HF files when we can just load them with Auto{Model,Config}.from_pretrained()
2 participants
What does this PR do?
Merging dkorzekwa/any_model_other_models into dkorzekwa/mip_and_realize_models - this MR is only for reviewing. Ultimately dkorzekwa/any_model_other_models should be merged into feature/puzzletron once dkorzekwa/mip_and_realize_models is merged there.