Open
Conversation
sidnhs
requested changes
Mar 4, 2026
sidnhs
approved these changes
Mar 4, 2026
| variable "event_publishing_anomaly_band_width" { | ||
| type = number | ||
| description = "The width of the anomaly detection band. Higher values (e.g. 4-6) reduce sensitivity and noise, lower values (e.g. 2-3) increase sensitivity. Recommended: 2-4." | ||
| default = 5 |
Contributor
There was a problem hiding this comment.
I think 5 might be too high? From what I understand it's based on standard deviation. 5 standard deviations is like 99.9999% of all data
|
|
||
| alarm_name = "${local.csi}-subscriber-anomaly" | ||
| alarm_description = "ANOMALY: Detects anomalous patterns in messages published to the SNS fanout topic" | ||
| comparison_operator = "LessThanLowerOrGreaterThanUpperThreshold" |
Contributor
There was a problem hiding this comment.
About LessThanLower - do we want to alert on drops too? I think there'll be periods when not in use?
| return_data = true | ||
|
|
||
| metric { | ||
| metric_name = "NumberOfMessagesPublished" |
Contributor
There was a problem hiding this comment.
Do we want NumberOfNotificationsDelivered here instead?
| metric_query { | ||
| id = "ad1" | ||
| expression = "ANOMALY_DETECTION_BAND(m1, ${var.event_anomaly_band_width})" | ||
| label = "NumberOfMessagesPublished (expected)" |
Contributor
There was a problem hiding this comment.
NumberOfNotificationsDelivered?
Comment on lines
+109
to
+112
| validation { | ||
| condition = var.event_anomaly_band_width >= 2 && var.event_anomaly_band_width <= 10 | ||
| error_message = "Band width must be between 2 and 10" | ||
| } |
Contributor
There was a problem hiding this comment.
Needed here? Is the anomaly threshold particularly important here? Again, I think 5 is already big
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding Anomaly alarms for Event Subscriptions
Bumping EventPub module to add Anomaly alarms for Event Publishing
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.