Conversation
**NOTE** We can not check Logstash OSS full cluster anymore!
afeefghannam89
left a comment
afeefghannam89
left a comment
There was a problem hiding this comment.
Now, my comments should work ;)
| node.roles: [ {% for type in elasticsearch_node_types %}{{ type }}{% if not loop.last %}, {% endif %}{% endfor %} ] | ||
| {% endif %} | ||
|
|
||
| {% if elasticstack_release | int > 7 and groups[elasticstack_elasticsearch_group_name] | length == 1 %} |
There was a problem hiding this comment.
Why do we need to remove this? What when the cluster has only one node? https://www.elastic.co/docs/deploy-manage/deploy/self-managed/bootstrap-checks#single-node-discovery
I think, in the future we should think about the approach of such an automated configuration. Here for example is not possible to switch to multi node, if the user want to extend his cluster later.
There was a problem hiding this comment.
I thought, this setting is only valid in Elasticsearch 7? Damn. Thanks for finding that - I'll revert the change.
There was a problem hiding this comment.
Totally mixed up < and >. facepalm
| {% if elasticstack_variant == "elastic" %} | ||
| xpack.ml.enabled: {{ elasticsearch_ml_enabled }} | ||
| {% if elasticstack_release == 7 %} | ||
| xpack.monitoring.collection.enabled: {{ elasticsearch_monitoring_enabled }} |
There was a problem hiding this comment.
The elasticsearch_monitoring_enabled still in
There was a problem hiding this comment.
Great find! Will remove it. I looked it up, the setting is still "valid", but doesn't do anything since some later 7.x.
docs/role-repos.md
Outdated
There was a problem hiding this comment.
This information is deprecated and not right.
There was a problem hiding this comment.
Right. I changed the line. Better?
Falling back to default
Thanks @afeefghannam89 for noticing this error!
Remove `and` with no left part
2 participants
Remove version 7 of Elastic Stack from supported versions.
This also means removing OSS versions for Elasticsearch and Kibana.
closes #289