Skip to content

67 move config validation to before lock file is acquired #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Lagejohn wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −3
Draft

67 move config validation to before lock file is acquired #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mmtc-core/src/main/java/edu/jhuapl/sd/sig/mmtc/app/MmtcCli.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ public static void main(String[] args) throws Exception {

try {
cfg = new MmtcConfig();
cfg.validate();
} catch (Exception e) {
logger.fatal("MMTC correlation initialization failed.");
throw new MmtcException("MMTC correlation initialization failed.", e);
Expand Down
2 changes: 0 additions & 2 deletions mmtc-core/src/main/java/edu/jhuapl/sd/sig/mmtc/app/TimeCorrelationApp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@ public TimeCorrelationApp(TimeCorrelationRunConfig config) throws MmtcException
* the specified SPICE kernels. Load the SCLK kernel separately.
*/
private void init() throws Exception {
config.validate();

new BuiltInOutputProductMigrationManager(config).assertExistingProductsDoNotRequireMigration();

logger.debug("Loading SPICE library");
Expand Down
2 changes: 1 addition & 1 deletion mmtc-core/src/main/java/edu/jhuapl/sd/sig/mmtc/cfg/TimeCorrelationRunConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ public Map<String, TimeCorrelationFilter> getFilters() throws MmtcException {
}

public boolean isCreateUplinkCmdFile() {
if (this.runConfigInputs.isCreateUplinkCmdFile) {
if (this.runConfigInputs != null && this.runConfigInputs.isCreateUplinkCmdFile) {
return true;
}

Expand Down