fix: use SKILL_DIR-based script paths and harden minimax-docx setup script#36
Open
GeederX wants to merge 2 commits intoMiniMax-AI:mainfrom
Open
fix: use SKILL_DIR-based script paths and harden minimax-docx setup script#36GeederX wants to merge 2 commits intoMiniMax-AI:mainfrom
GeederX wants to merge 2 commits intoMiniMax-AI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two execution reliability issues in skill docs and setup scripts:
Relative script paths in skill docs could fail when the agent working directory is not the skill folder.
The minimax-docx setup shell script had cross-platform issues (CRLF line endings and sudo assumptions).
What changed
Standardized script invocation in skill markdown files to use SKILL_DIR-based absolute paths.
Added explicit guidance to set SKILL_DIR once per session in affected skills.
Updated minimax-docx setup script to support both root and non-root environments:
run commands directly when running as root
use sudo only when needed and available
show clear error when elevated privileges are required but sudo is missing
Normalized minimax-docx setup shell script line endings to LF for bash compatibility.
Why
These changes reduce environment-dependent failures and improve reproducibility across different agent working directories, OS setups, and privilege models.
##Impact
No behavior change for users already running from the correct skill directory.
Improved robustness for agent execution in non-skill working directories.
Improved Linux/WSL setup reliability for minimax-docx.
Validation
Reviewed all updated script command examples in affected skill docs.
Verified minimax-docx setup script no longer hard-depends on sudo for root execution.
Verified LF normalization for setup shell script.
#35