Skip to content

Make everyting declarative #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
LexManos wants to merge 5 commits into
base: FD_7.0
Choose a base branch
from
Draft

Make everyting declarative #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8746a93
WIP
LexManos Apr 14, 2026
06e0d8e
Rewrite source patching tasks to optionally extract as a last step
LexManos Apr 14, 2026
4868b94
Minor fixes, change how WriteManifest is registered to make task grap…
LexManos Apr 15, 2026
1ef182e
Fix binary patches and other minor things.
LexManos Apr 18, 2026
d8af1a7
Fix a few task ordering issues. And parsing promotions_slim.json
LexManos Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,6 @@ gradlePlugin {
tags = ['minecraftforge']
}

register('forge') {
id = 'net.minecraftforge.forge.build.forge'
implementationClass = 'net.minecraftforge.forgedev.legacy.ForgeBuildPlugin'
}

register('convention') {
id = 'net.minecraftforge.forge.build.convention'
implementationClass = 'net.minecraftforge.forgedev.legacy.SharedBuildPlugin'
Expand Down
7 changes: 5 additions & 2 deletions settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ gradle.beforeProject { Project project ->

//@formatter:off
dependencyResolutionManagement.versionCatalogs.register('libs') {
version 'gradleutils', '3.4.4'
version 'gradleutils', '3.4.5'

plugin 'licenser', 'net.minecraftforge.licenser' version '1.2.0'
plugin 'gradleutils', 'net.minecraftforge.gradleutils' versionRef 'gradleutils'
Expand All @@ -41,12 +41,15 @@ dependencyResolutionManagement.versionCatalogs.register('libs') {
// Plugins
library 'gradle-download', 'de.undercouch.download', 'de.undercouch.download.gradle.plugin' version '5.6.0'

// Access to git info, namely finding out version for the validation tasks
library 'jgit', 'org.eclipse.jgit:org.eclipse.jgit:7.6.0.202603022253-r'

version 'asm', '9.8'
library 'asm', 'org.ow2.asm', 'asm' versionRef 'asm'
library 'asm-tree', 'org.ow2.asm', 'asm-tree' versionRef 'asm'
bundle 'asm', ['asm', 'asm-tree']

library 'srgutils', 'net.minecraftforge', 'srgutils' version '0.5.14'
library 'srgutils', 'net.minecraftforge', 'srgutils' version '0.6.2'
library 'fastcsv', 'de.siegmar', 'fastcsv' version '3.7.0'
library 'jarjar', 'net.minecraftforge', 'JarJarMetadata' version '0.4.2'
library 'maven-artifact', 'org.apache.maven', 'maven-artifact' version '3.8.8'
Expand Down
2 changes: 1 addition & 1 deletion ...orgedev/legacy/tasks/CleanProperties.java → ...ecraftforge/forgedev/CleanProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Copyright (c) Forge Development LLC and contributors
* SPDX-License-Identifier: LGPL-2.1-only
*/
package net.minecraftforge.forgedev.legacy.tasks;
package net.minecraftforge.forgedev;

import java.io.ByteArrayOutputStream;
import java.io.File;
Expand Down
9 changes: 5 additions & 4 deletions src/main/groovy/net/minecraftforge/forgedev/Constants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@
*/
package net.minecraftforge.forgedev;

/// The package-private constants used throughout ForgeGradle.
final class Constants {
/// The constants used throughout ForgeGradle.
public final class Constants {
private Constants() { }

static final String FORGE_MAVEN = "https://maven.minecraftforge.net/";
static final String MAVEN_CENTRAL = "https://repo1.maven.org/maven2/";
public static final String FORGE_MAVEN = "https://maven.minecraftforge.net/";
public static final String FORGE_FILES = "https://files.minecraftforge.net/";
public static final String MAVEN_CENTRAL = "https://repo1.maven.org/maven2/";
}
Loading