Skip to content

feat: submit batch sell quotes #8775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
micaelae wants to merge 10 commits into
base: swaps4229-submitTx-strategy-refactor
Choose a base branch
from
Draft

feat: submit batch sell quotes #8775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5359aa2
feat: handle multiple quoteResponses in submit params
micaelae May 8, 2026
191fb1f
chore: BatchSimulationResponse
micaelae May 8, 2026
cf59c1c
refactor: transaction params, gas calculation
micaelae May 12, 2026
5d428b0
feat: BatchSell submission
micaelae May 12, 2026
4671788
wip
micaelae May 12, 2026
9b264eb
test wip
micaelae May 12, 2026
24c2026
fix: undo signature change
micaelae May 12, 2026
84e9564
Merge branch 'swaps4229-submitTx-strategy-refactor' into swaps4458-su…
micaelae May 13, 2026
e7c6313
feat: fetch batch sell trades
micaelae May 14, 2026
812aa2e
feat: batch-sell-strategy
micaelae May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/bridge-controller/src/__snapshots__/bridge-controller.sse.batch.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`BridgeController BatchSell (multiple quote requests) SSE should trigger quote polling if request is valid 1`] = `
exports[`BridgeController BatchSell (multiple quote requests) SSE fetch quotes should trigger quote polling if request is valid 1`] = `
{
"assetExchangeRates": {
"eip155:10/erc20:0x1f9840a85d5af5bf1d1762f925bdaddc4201f984": {
"exchangeRate": undefined,
"usdExchangeRate": "100",
},
},
"batchSellTrades": null,
"batchSellTradesLoadingStatus": null,
"minimumBalanceForRentExemptionInLamports": "0",
"quoteFetchError": null,
"quoteRequest": [
Expand Down Expand Up @@ -58,7 +60,7 @@ exports[`BridgeController BatchSell (multiple quote requests) SSE should trigger
}
`;

exports[`BridgeController BatchSell (multiple quote requests) SSE should trigger quote polling if request is valid 2`] = `
exports[`BridgeController BatchSell (multiple quote requests) SSE fetch quotes should trigger quote polling if request is valid 2`] = `
[
[
"Unified SwapBridge Input Changed",
Expand Down
4 changes: 4 additions & 0 deletions packages/bridge-controller/src/__snapshots__/bridge-controller.sse.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,8 @@ exports[`BridgeController SSE should rethrow error from server 1`] = `
"usdExchangeRate": "100",
},
},
"batchSellTrades": null,
"batchSellTradesLoadingStatus": null,
"minimumBalanceForRentExemptionInLamports": "0",
"quoteFetchError": null,
"quoteRequest": [
Expand Down Expand Up @@ -303,6 +305,8 @@ exports[`BridgeController SSE should trigger quote polling if request is valid 1
"usdExchangeRate": "100",
},
},
"batchSellTrades": null,
"batchSellTradesLoadingStatus": null,
"minimumBalanceForRentExemptionInLamports": "0",
"quoteFetchError": null,
"quoteRequest": [
Expand Down
8 changes: 8 additions & 0 deletions packages/bridge-controller/src/__snapshots__/bridge-controller.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ exports[`BridgeController should handle errors from fetchBridgeQuotes 1`] = `
"usdExchangeRate": "100",
},
},
"batchSellTrades": null,
"batchSellTradesLoadingStatus": null,
"minimumBalanceForRentExemptionInLamports": "0",
"quoteFetchError": null,
"quoteRequest": [
Expand Down Expand Up @@ -39,6 +41,8 @@ exports[`BridgeController should handle errors from fetchBridgeQuotes 2`] = `
"usdExchangeRate": "100",
},
},
"batchSellTrades": null,
"batchSellTradesLoadingStatus": null,
"minimumBalanceForRentExemptionInLamports": "0",
"quoteFetchError": null,
"quoteRequest": [
Expand Down Expand Up @@ -829,6 +833,8 @@ exports[`BridgeController updateBridgeQuoteRequestParams should reset minimumBal
exports[`BridgeController updateBridgeQuoteRequestParams should trigger quote polling if request is valid 1`] = `
{
"assetExchangeRates": {},
"batchSellTrades": null,
"batchSellTradesLoadingStatus": null,
"minimumBalanceForRentExemptionInLamports": "0",
"quoteFetchError": null,
"quoteRequest": [
Expand Down Expand Up @@ -864,6 +870,8 @@ exports[`BridgeController updateBridgeQuoteRequestParams should trigger quote po
"usdExchangeRate": "100",
},
},
"batchSellTrades": null,
"batchSellTradesLoadingStatus": null,
"minimumBalanceForRentExemptionInLamports": "0",
"quoteFetchError": null,
"quoteRequest": [
Expand Down
8 changes: 7 additions & 1 deletion packages/bridge-controller/src/bridge-controller-method-action-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ export type BridgeControllerTrackUnifiedSwapBridgeEventAction = {
handler: BridgeController['trackUnifiedSwapBridgeEvent'];
};

export type BridgeControllerFetchBatchSellTradesAction = {
type: `BridgeController:fetchBatchSellTrades`;
handler: BridgeController['fetchBatchSellTrades'];
};

/**
* Union of all BridgeController action types.
*/
Expand All @@ -50,4 +55,5 @@ export type BridgeControllerMethodActions =
| BridgeControllerSetLocationAction
| BridgeControllerResetStateAction
| BridgeControllerSetChainIntervalLengthAction
| BridgeControllerTrackUnifiedSwapBridgeEventAction;
| BridgeControllerTrackUnifiedSwapBridgeEventAction
| BridgeControllerFetchBatchSellTradesAction;
Loading
Loading