fix: remove Leaderboard block from Dashboard#1792
Closed
Ai-chan-0411 wants to merge 1 commit intoMetaFam:developfrom
Closed
fix: remove Leaderboard block from Dashboard#1792Ai-chan-0411 wants to merge 1 commit intoMetaFam:developfrom
Ai-chan-0411 wants to merge 1 commit intoMetaFam:developfrom
Conversation
Remove stagnant leaderboard section that displays outdated/incorrect XP data. - Remove Leaderboard from default and available dashboard boxes - Remove Leaderboard case from DashboardSection renderer - Remove layout height config for leaderboard - Keep BoxTypes enum value to avoid breaking stored user layouts
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
@aoi-dev-0411 is attempting to deploy a commit to the MetaFamily Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Closing due to no review activity. Thank you for the opportunity! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1768
Removes the stagnant Leaderboard block from the Dashboard. The leaderboard displays outdated XP data and is misleading since XP is not an active system.
Changes
DASHBOARD_LEADERBOARDfromALL_BOXESandDEFAULT_BOXESin dashboard configLeaderboardcase fromDashboardSectionrendererBoxTypes.DASHBOARD_LEADERBOARDenum value to avoid breaking stored user layouts (existing layouts with leaderboard will render null gracefully)ref: #1656