#VFB-236 - Use v3 cache server and build backend only if flag set to true#220
#VFB-236 - Use v3 cache server and build backend only if flag set to true#220jrmartin wants to merge 6 commits intodevelopmentfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a build-time flag to optionally skip installing/building the backend in the Virtual Fly Brain Docker image, updates the dev deployment pipeline to pass that flag through, and repoints the frontend’s default API base URL to the v3 cached server.
Changes:
- Add Docker build arg
BUILD_BACKENDand conditionally run backend dependency/package installation based on its value. - Pass
BUILD_BACKENDthrough the Codefresh dev pipeline into the Docker build. - Update the frontend Vite config default API URL to the v3 cached endpoint.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
deployment/codefresh-dev.yaml |
Forwards BUILD_BACKEND as a Docker build argument in the dev pipeline. |
applications/virtual-fly-brain/frontend/vite.config.js |
Changes the fallback API URL used when VFB_DOMAIN is not provided. |
applications/virtual-fly-brain/Dockerfile |
Adds conditional backend install/build steps controlled by BUILD_BACKEND. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8187c6fa21
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Conditional Backend Build:
BUILD_BACKENDto the Dockerfile, which controls whether backend dependencies and the backend itself are installed during the Docker build. IfBUILD_BACKENDis set to"false", backend installation steps are skipped, improving build flexibility. [1] [2]codefresh-dev.yaml) to pass theBUILD_BACKENDenvironment variable to the Docker build process, ensuring consistent behavior across environments.Frontend Configuration:
vite.config.jsto usehttps:/v3-cached.virtualflybrain.orginstead of the previous development URL, aligning the frontend with the new backend endpoint.