Rename slotSnapshot→fieldSnapshot and missingSlots→missingFields in proposal entity data#73
Open
MaxLinCode wants to merge 1 commit intoclaude/phase1-pending-write-operationfrom
Open
Conversation
…roposal entity data Aligns proposal_option entity schema with the field-based model introduced in phase 1. Also separates targetEntityId from scheduleFields in synthesize-mutation-text since target is no longer part of the schedule fields group (it lives in targetRef on PendingWriteOperation). - index.ts: missingSlots→missingFields, slotSnapshot→fieldSnapshot - proposal-rules.ts: remove flattenScheduleFields adapter, compare scheduleFields directly, rename deriveSlotsCompatibility→deriveFieldsCompatibility - synthesize-mutation-text.ts: accept resolvedFields + targetEntityId, rename internal helpers to field-based names - discourse-state.ts: update comment on resolvedSlotsSchema retention - All tests updated to match new schema shape Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
missingSlots→missingFieldsandslotSnapshot→fieldSnapshotin theproposal_optionentity schema to align with the field-based model from phase 1flattenScheduleFieldsadapter inproposal-rules.ts— now comparesscheduleFieldsdirectly against the snapshottargetEntityIdfrom schedule fields insynthesize-mutation-text.tssincetargetis no longer part ofscheduleFields(it lives intargetRefonPendingWriteOperation)discourse-state.tscomment to noteresolvedSlotsSchemais retained only for slot-extractor schemas (phase 2 scope)Test plan
pnpm --filter @atlas/core typecheckpassespnpm --filter @atlas/core testpasses (125 tests)apps/webandpackages/dbtests are updated in follow-up (these still reference old field names)🤖 Generated with Claude Code