MDEV-38805:Store optimizer_context into a IS table#4675
Open
bsrikanth-mariadb wants to merge 7 commits into12.3-MDEV-38701-dev-sprint-work-1from
Open
MDEV-38805:Store optimizer_context into a IS table#4675bsrikanth-mariadb wants to merge 7 commits into12.3-MDEV-38701-dev-sprint-work-1from
bsrikanth-mariadb wants to merge 7 commits into12.3-MDEV-38701-dev-sprint-work-1from
Conversation
bsrikanth-mariadb
force-pushed
the
12.3-MDEV-38805-dev-sprint-work-2
branch
3 times, most recently
from
a370860 to
33ffc88
Compare
bsrikanth-mariadb
force-pushed
the
12.3-MDEV-38805-dev-sprint-work-2
branch
15 times, most recently
from
6a89329 to
4202b27
Compare
bsrikanth-mariadb
force-pushed
the
12.3-MDEV-38805-dev-sprint-work-2
branch
from
4202b27 to
4693768
Compare
Currently, optimizer context is written as JSON sub-element in the Optimizer Trace. In this task, we separate it out from the optimizer trace, and instead store it in optimizer_context Information Schema table. The structure of the context is changed to look like below: - ---------------------------------- SET var_name1=val1; SET var_name2=val2; . . . CREATE TABLE t1 ( ... ); -- in case it is a constant table REPLACE INTO t1 VALUES (...); CREATE TABLE t2 ( ... ); ... set @context='{ JSON with all the captured calls }'; set @optimizer_context='context'; ... the original query; ---------------------------------- The IS can be used to read the current stored context, as well as to dump it to a sql file which can later be replayed in a different environment. It is done like below: - -------------------------------------- set optimizer_record_context=ON; set optimizer_trace=1 -- sample query select into outfile '/tmp/captured-context.sql' context from information_schema.OPTIMIZER_CONTEXT; --------------------------------------- All the existing tests are modified to query OPTIMIZER_CONTEXT IS table
bsrikanth-mariadb
force-pushed
the
12.3-MDEV-38805-dev-sprint-work-2
branch
from
4693768 to
379a30c
Compare
s/dump_eits_stats_helper/append_insert_for_current_row/ Use String::append(LEX_STRING).
1. Add escaping in strings if they contain quotes in the names 2. Record CONST insert statement for MYISAM system table 3. Add tests to oad the sql_script file that is produced with record_context=ON and then use it to run same queries on empty tables.
1. store round_cost() in a separate .inc file so that it can be reused across multiple tests 2. Change the usage of "--error 1290" with "--error ER_OPTION_PREVENTS_STATEMENT"
bsrikanth-mariadb
force-pushed
the
12.3-MDEV-38805-dev-sprint-work-2
branch
from
fbbed34 to
d74f227
Compare
- Introduce init_optimizer_context_recorder_if_needed() which is called at query start. We n longer create the recorder lazily. - Recorder functions no longer take MEM_ROOT to store data on as an argument. The recorder knows the MEM_ROOT it should use.
REPLACE INTO statements would now use my_charset_utf8mb4_bin conversion Also, the sql_script file structure would now look like SET NAMES utf8mb4; SET var1=value1; . . CREATE DATABASE 'name' if NOT..; USE DATABASE 'name'; CREATE TABLE ...; . REPLACE INTO ..; . . set @opt_context='...'; . . Additionally, made few changes to the documentation comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, optimizer context is written as JSON sub-element in the Optimizer Trace.
In this task, we separate it out from the optimizer trace, and instead store it in optimizer_context Information Schema table.
The structure of the context is changed to look like below:
SET var_name1=val1;
SET var_name2=val2;
.
.
.
CREATE TABLE t1 ( ... );
-- in case it is a constant table
REPLACE INTO t1 VALUES (...);
CREATE TABLE t2 ( ... );
...
set @context='{ JSON with all the captured calls }'; set @optimizer_context='context';
the original query;
The IS can be used to read the current stored context, as well as to dump it to a sql file which can later be replayed in a different environment.
It is done like below: -
set optimizer_record_context=ON;
set optimizer_trace=1
-- sample query
select into outfile '/tmp/captured-context.sql' context from information_schema.OPTIMIZER_CONTEXT;
All the existing tests are modified to query OPTIMIZER_CONTEXT IS table