feat: infrastructure and boilerplate deps upgrade (MAPCO-9937) by roicohen326 · Pull Request #82 · MapColonies/ingestion-trigger

roicohen326 · 2026-03-12T15:07:45Z

Question	Answer
Bug fix	✖
New feature	✔
Breaking change	✖
Deprecations	✖
Documentation	✖
Tests added	✖
Chore	✖

Related issues: #XXX , #XXX ...
Closes #XXX ...

Further information:

CL-SHLOMIKONCHA

Nice job, focus on:

merge similar imports
IConfig should be removed and replaced by : ConfigType
Also remove tsconfig.lint.json & tsconfig.test.json
Eslint error
Failed tests
Some missing config-management envs

CL-SHLOMIKONCHA · 2026-03-15T11:04:47Z

+{{/*
+Returns the metrics url from global if exists or from the chart's values
+*/}}
+{{- define "ingestion-trigger.metricsUrl" -}}


metrics url is redundant

CL-SHLOMIKONCHA · 2026-03-15T11:05:17Z

+{{/*
+Returns the metrics buckets from global if exists or from the chart's values
+*/}}
+{{- define "ingestion-trigger.metricsBuckets" -}}


metrics buckets is redundant

CL-SHLOMIKONCHA · 2026-03-15T11:11:03Z

would prefer to remain work with the common.tracing.merged within the _tplValues.tpl file

CL-SHLOMIKONCHA · 2026-03-15T13:08:25Z

-  {{ if $metrics.enabled }}
-  TELEMETRY_METRICS_ENABLED: {{ $metrics.enabled | quote }}
-  TELEMETRY_METRICS_URL: {{ $metrics.url }}
+  TELEMETRY_METRICS_ENABLED: {{ $metricsEnabled | quote }}


matrics envs redundant

CL-SHLOMIKONCHA · 2026-03-15T13:09:37Z

missing configManagement envs

CL-SHLOMIKONCHA · 2026-03-15T13:46:52Z

+    openAsync: jest.fn().mockImplementation(actualModule['openAsync'] as (...args: unknown[]) => unknown),
+  };
+});
 import httpStatusCodes from 'http-status-codes';


handle those eslint errors

CL-SHLOMIKONCHA · 2026-03-15T13:48:06Z

+  });
+
  beforeEach(() => {
+    registerDefaultConfig();


please recheck this one, should not be called after the getApp?

CL-SHLOMIKONCHA · 2026-03-15T13:48:58Z

 import { trace } from '@opentelemetry/api';
+import * as gdal from 'gdal-async';
+
+jest.mock('gdal-async', () => {


usually jest.mock must be shown above all import, please recheck it.

CL-SHLOMIKONCHA · 2026-03-15T13:49:27Z

 bundledApi.yaml

+# Temporary schema files
+Schema/


You are right, this was added during cleanup of local generated files and is not required for this PR, so I will remove it.

CL-SHLOMIKONCHA · 2026-03-15T13:55:06Z

should see why you had to use taskId with !

After the ESLint v9 migration, stricter rules exposed older tolerated patterns, so I fixed the real code issues first and used a few tactical suppressions only where external package conventions didn’t align with lint rules.
These suppressions are short term safeguards for migration stability, and I will remove them as part of targeted cleanup refactors in the upcoming PR.

CL-SHLOMIKONCHA · 2026-05-10T08:26:37Z

please upgrade js-logger to v5.0.0 support the loki telemetry,
see more:
MapColonies/ts-server-boilerplate@85862fa

CL-SHLOMIKONCHA · 2026-05-10T11:45:20Z

+  {{ if $tracing.enabled }}
+  TELEMETRY_TRACING_URL: {{ $tracing.url }}
  {{ end }}
+  CONFIG_SERVER_URL: {{ .Values.configManagement.serverUrl | quote }}


please convert to use the with syntax:
{{- with .Values.configManagement }}
see more: https://github.com/MapColonies/ts-server-boilerplate/blob/master/helm/templates/configmap.yaml

CL-SHLOMIKONCHA · 2026-05-10T11:45:35Z

+  OFFLINE_MODE: {{ .Values.configManagement.offlineMode | quote }}
  npm_config_cache: /tmp/
 {{- end }}
 # TODO: check if values should be clean up


CL-SHLOMIKONCHA · 2026-05-10T11:49:38Z

  logPrettyPrintEnabled: false
  responseCompressionEnabled: true
  requestPayloadLimit: 1mb
-  tracing:


we still need the tracing scope to determine to enabled and set the telemetry url

CL-SHLOMIKONCHA · 2026-05-10T11:51:12Z

+        logContext: this.logContext,
+        jobId: task.jobId,
+        taskId: task.id,
+        error: err instanceof Error ? err.message : 'Unknown error',


change to err (run linter again - if theres more of this warning please fix)

CL-SHLOMIKONCHA · 2026-05-10T11:52:03Z

recheck this warning

CL-SHLOMIKONCHA · 2026-05-10T11:53:23Z

+        if (err instanceof Error) {
+          const message = 'Failed to notify job tracker';
+          const error = new Error(`${message}: ${err.message}`);
+          logger.error({ msg: message, error: err });


same comment - change to err

CL-SHLOMIKONCHA · 2026-05-10T11:53:53Z

          this.logger.error({ msg: 'error processing checksum for a chunk', err, logContext: logCtx });
          stream.destroy();
-          reject(err);
+          reject(err instanceof Error ? err : new Error(String(err)));


CL-SHLOMIKONCHA · 2026-05-10T11:53:58Z

          this.logger.error({ msg: 'error processing checksum result', err, logContext: logCtx });
          stream.destroy();
-          reject(err);
+          reject(err instanceof Error ? err : new Error(String(err)));


CL-SHLOMIKONCHA · 2026-05-10T11:56:27Z

why did you delete this file? its needed to init config and tracing, server would not run without this one.

CL-SHLOMIKONCHA · 2026-05-10T11:56:51Z

  afterEach(function () {
    resetContainer();
    jest.restoreAllMocks();
    nock.cleanAll();


add ignore rule for this case

…gmap with syntax

roicohen326 added 2 commits March 12, 2026 17:06

feat: infrastructure and boilerplate deps upgrade

c9a89d3

style: fix formatting in gdalUtilities.spec.ts

15800ea

CL-SHLOMIKONCHA requested changes Mar 15, 2026

View reviewed changes

roicohen326 and others added 10 commits March 18, 2026 10:57

fix(helm): remove redundant telemetry helper values

cf24a33

fix: migrate IConfig to ConfigType

2a360cc

chore: minor whitespace

4026f27

chore: merge master to resolve conflicts

c9d7dfe

fix: regenerate package-lock.json for npm ci compatibility

020ac1e

fix: lint errors

20b7247

test: add polygon parts manager 404 and 500 coverage tests

255b8f5

fix: address PR review comments

2618c5e

chore: merge master into branch

692772f

chore: regenerate package-lock.json

136b329

roicohen326 added 2 commits May 10, 2026 13:45

fix: upgrade js logger to v5

11c712a

chore: add .diff to gitignore

2f60e4d

CL-SHLOMIKONCHA requested changes May 10, 2026

View reviewed changes

roicohen326 added 2 commits May 11, 2026 13:49

fix: use err shorthand in logger calls, fix lint warnings, helm confi…

7018cfd

…gmap with syntax

fix: revert booleanContains to default import

4743f7c

Conversation

roicohen326 commented Mar 12, 2026

Uh oh!

CL-SHLOMIKONCHA left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CL-SHLOMIKONCHA commented May 10, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants