Compute, rather than read from input, deformation_coef_* fields at model startup#1419
Draft
mgduda wants to merge 2 commits intoMPAS-Dev:developfrom
Draft
Compute, rather than read from input, deformation_coef_* fields at model startup#1419mgduda wants to merge 2 commits intoMPAS-Dev:developfrom
deformation_coef_* fields at model startup#1419mgduda wants to merge 2 commits intoMPAS-Dev:developfrom
Conversation
…del startup
This commit removes the deformation_coef_{c2,s2,cs,c,s} fields from the
definition of the 'invariant' stream in the atmosphere core's Registry.xml file
(effectively removing them from the 'input' and 'restart' streams as well), and
adds a new routine, atm_initialize_deformation_weights, to the atm_core module
to compute these fields at model start-up.
…sphere core
This commit removes the deformation_coef_{c2,s2,cs,c,s} fields from the
init_atmosphere core, including the removal of these fields from the
init_atmosphere core's Registry.xml file as well as the removal of code
in the atm_advection module for computing these fields.
mgduda
changed the title
deformation_coef_* fields at model startup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies both the
init_atmosphereandatmospherecores so that thedeformation_coef_{c2,s2,cs,c,s}fields are computed by the model during its initialization rather than being read from a netCDF input file (either an invariant file, an initial conditions file, or a restart file).The changes in this PR may be logically viewed as occurring in three steps:
atmospherecore to compute thedeformation_coef_{c2,s2,cs,c,s}fields at model start up using identical code to that which is found in theinit_atmospherecoredeformation_coef_{c2,s2,cs,c,s}fields from theatmospherecore's 'invariant' stream (effectively removing these fields from the 'input' and 'restart' streams as well) so the fields are no longer read from netCDF input files.deformation_coef_{c2,s2,cs,c,s}fields and their computation from theinit_atmospherecore.