Fix GPS extraction for ImageMagick string format#80
Open
hyazinthh wants to merge 1 commit intoLycheeOrg:masterfrom
Open
Fix GPS extraction for ImageMagick string format#80hyazinthh wants to merge 1 commit intoLycheeOrg:masterfrom
hyazinthh wants to merge 1 commit intoLycheeOrg:masterfrom
Conversation
Update the GPS coordinate regex to handle variations in whitespace. Newer versions of ImageMagick appear to omit the space after commas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the GPS coordinate regex to account for variations in whitespace.
On my system ImageMagick does not output any whitespace after the commas, making extraction fail with current regex:
$ identify -format "%[EXIF:GPSLatitude]\n" tests/files/mongolia.jpeg 46/1,53903520/1000000,0/1I assume this is version dependent but I haven't investigated any further.