Skip to content

Fix install.sh not aborting on Ctrl+C or sudo failure #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
albertodebortoli merged 2 commits into from
Mar 26, 2026
+8 −0
Merged

Fix install.sh not aborting on Ctrl+C or sudo failure #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
617fbec
Abort installation on SIGINT (Ctrl+C)
albertodebortoli Mar 26, 2026
a2b92c5
Abort installation on sudo or command failure in sudo_if_install_dir_…
albertodebortoli Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ POST_CHECKOUT_HOOK_URL="https://raw.githubusercontent.com/LucaTools/LucaScripts/
# GITHUB API AUTHENTICATION
# =============================================================================

trap 'printf "\n❌ Installation interrupted.\n"; exit 130' INT

# Build curl options for GitHub API requests.
# If GITHUB_TOKEN is set, include it as a Bearer token to avoid rate limiting
# (5000 req/hr authenticated vs. 60 req/hr unauthenticated).
Expand Down Expand Up @@ -210,6 +212,7 @@ echo "🧹 Cleaned up temporary files"
# This checks if the install directory is writable before using sudo
sudo_if_install_dir_not_writeable() {
local command="$1"
local exit_code
if [ -w "$INSTALL_DIR" ]; then
# Directory is writable, run without sudo
sh -c "$command"
Expand All @@ -218,6 +221,11 @@ sudo_if_install_dir_not_writeable() {
echo "🔐 Administrator privileges required for installation to $INSTALL_DIR"
sudo sh -c "$command"
fi
exit_code=$?
if [ "$exit_code" -ne 0 ]; then
echo "❌ ERROR: Command failed or was interrupted (exit code: $exit_code)"
exit "$exit_code"
fi
}

# Create install directory if it doesn't exist
Expand Down
Loading