Skip to content

Use PageFlowUtil.jsString to escape container path #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vagisha merged 4 commits into from
Mar 22, 2025
Merged

Use PageFlowUtil.jsString to escape container path #522

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0dfd6f0
Use PageFlowUtil.jsString to escape container path.
vagisha Mar 13, 2025
ebb8ffb
id is a non-null Integer, so does not need to be quoted when passing …
vagisha Mar 20, 2025
0fc25a3
HTML-escape the abstract, experiment and sample descriptions displaye…
vagisha Mar 20, 2025
cd69a77
Update panoramapublic/webapp/PanoramaPublic/js/dropDownUtil.js
vagisha Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion panoramapublic/src/org/labkey/panoramapublic/query/ExperimentAnnotationsTableInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,10 @@ public void renderGridCellContents(RenderContext ctx, Writer out) throws IOExcep
.at(src, PageFlowUtil.staticResourceUrl("_images/plus.gif"))),
HtmlString.NBSP)
.appendTo(out);
pageConfig.addHandler(spanId, "click", "viewExperimentDetails(this,'" + container.getPath() + "', '" + id + "','" + detailsPage + "')");
pageConfig.addHandler(spanId, "click", "viewExperimentDetails(this,"
+ PageFlowUtil.jsString(container.getPath())
+ ", '" + id + "', "
Copy link
Copy Markdown
Contributor

@labkey-jeckels labkey-jeckels Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well handle them all the same way.

Suggested change
+ ", '" + id + "', "
+ ", " + PageFlowUtil.jsString(id) + ", "

Copy link
Copy Markdown
Collaborator Author

@vagisha vagisha Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'id' is a non-null Integer so does not need to be quoted, I think.

I added some HTML-escaping in related code. If you could take another look that would be great.

Copy link
Copy Markdown
Contributor

@labkey-jeckels labkey-jeckels Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I somehow thought it was a string.

+ PageFlowUtil.jsString(detailsPage) + ")");
}
super.renderGridCellContents(ctx, out);
}
Expand Down