Skip to content

ci: reduce UI test workers from -n4 to -n2 to prevent OOM kills#916

Merged
averevki merged 1 commit intoKuadrant:mainfrom
emmaaroche:reduce-ui-workers
Mar 31, 2026
Merged

ci: reduce UI test workers from -n4 to -n2 to prevent OOM kills#916
averevki merged 1 commit intoKuadrant:mainfrom
emmaaroche:reduce-ui-workers

Conversation

@emmaaroche
Copy link
Copy Markdown
Contributor

@emmaaroche emmaaroche commented Mar 30, 2026

Description

This PR reduces UI test parallelisation from -n4 to -n2 workers to prevent OOM kills during nightly test executions.

The memory limit was previously increased to 2500Mi to attempt to resolve this issue, see Kuadrant/testsuite-pipelines#157, but with additional overview UI tests added the pods sometimes still exceed memory and get OOMKilled (exit code 137).

I wanted to try this approach before increasing memory limits even more.

Performance comparison (this includes new policy tests from #915):

  • -n4: ~7 minutes
  • -n2: ~9 minutes
  • Trade-off: +28% execution time, but not enough for it to be an issue IMO

Changes

  • Makefile: Changed pytest parallelization flag from -n4 to -n2 for the make ui test target

Verification steps

Run UI tests locally to verify they run using ‘-n2’

make ui                                                                             

Signed-off-by: emmaaroche <eroche@redhat.com>
@emmaaroche emmaaroche self-assigned this Mar 30, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ca1ecab0-e272-4743-997a-f7354eba4381

📥 Commits

Reviewing files that changed from the base of the PR and between 1aee51b and ff5a6a3.

📒 Files selected for processing (1)
  • Makefile

📝 Walkthrough

Walkthrough

The Makefile's ui test target was modified to reduce pytest parallelism from four workers to two workers. The adjustment applies to Playwright UI tests whilst maintaining existing test selection, distribution strategy, and target paths.

Changes

Cohort / File(s) Summary
Makefile Configuration
Makefile
Reduced pytest worker count from -n4 to -n2 in the ui test target for Playwright UI tests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 With whiskers twitched and nose held high,
Four workers became just two, oh my!
The tests shall run at a gentler pace,
A smaller fleet in testing's race.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarises the main change: reducing UI test workers from 4 to 2 to prevent memory issues, which aligns perfectly with the Makefile modification.
Description check ✅ Passed The description includes all required sections (Description, Changes, Verification) with comprehensive detail about the rationale, performance impact, and testing approach.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@azgabur azgabur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can help 👍
Seems like playwright is experiencing some memory leaks for a long time microsoft/playwright#15400 not much we can do about that.

@averevki averevki merged commit 5e3e5c8 into Kuadrant:main Mar 31, 2026
7 checks passed
@emmaaroche emmaaroche deleted the reduce-ui-workers branch April 1, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants