ci: reduce UI test workers from -n4 to -n2 to prevent OOM kills#916
ci: reduce UI test workers from -n4 to -n2 to prevent OOM kills#916averevki merged 1 commit intoKuadrant:mainfrom
Conversation
Signed-off-by: emmaaroche <eroche@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Makefile's Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
azgabur
left a comment
There was a problem hiding this comment.
This can help 👍
Seems like playwright is experiencing some memory leaks for a long time microsoft/playwright#15400 not much we can do about that.
Description
This PR reduces UI test parallelisation from
-n4to-n2workers to prevent OOM kills during nightly test executions.The memory limit was previously increased to 2500Mi to attempt to resolve this issue, see Kuadrant/testsuite-pipelines#157, but with additional overview UI tests added the pods sometimes still exceed memory and get OOMKilled (exit code 137).
I wanted to try this approach before increasing memory limits even more.
Performance comparison (this includes new policy tests from #915):
Changes
Makefile: Changed pytest parallelization flag from-n4to-n2for themake uitest targetVerification steps
Run UI tests locally to verify they run using ‘-n2’