Conversation
zkraus
requested review from
averevki,
azgabur,
crstrn13,
emmaaroche,
fabikova,
silvi-t,
tomas-jochec and
trepel
averevki
left a comment
averevki
left a comment
There was a problem hiding this comment.
Maybe something we can convert to project's claude.md context file down the road. LGTM now 👍
emmaaroche
left a comment
emmaaroche
left a comment
There was a problem hiding this comment.
Left a few small suggestions to add to the Commits and Creating PRs sections, feel free to apply, modify, or decline them as you see fit 😄
azgabur
left a comment
azgabur
left a comment
There was a problem hiding this comment.
Want to review/collaborate before merge, just need to find time
|
@averevki I am sorry, this slipped off my radar due to other priorities, and as you mentioned, it might not be relevant anymore, are we defining the workflows for Claude. Do you think it's still worth having this? Should you pick it back up, and continue? |
|
I'm actually fine with also having a smaller design guide for a human eye read. Should we use CLAUDE.md only for processing by AI? This way we could keep CLAUDE.md large and don't care about readability in there much. I know @azgabur had an opinion about testsuite designing doc, would be great to get his thoughts on this |
|
Indeed I cant find time to properly put my thoughts in a document about how the changes to the testsuite should be made. But I can see the Claude.md already has some pointers. Human is just an another AI (but just I) so maybe the work could be merged in one file. |
|
I think, it would be smarter to have a human readable summary written down. And have CLAUDE.md or any other claude specific md file optimized for Claude. Even though that would mean we need to keep them all in sync. Let me try to distill the essence of it from CLAUDE.md and we can review the result. |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 36 minutes and 46 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Rebased to main (not latest, need to do another one 🤦 ), and updated DESIGN_DOCS from CLAUDE.md |
Design guide is suppose to be a set of guidelines and tips on how to desing tests, write commits, submit a review PRs, and anything that might be usefull.
Co-authored-by: Emma Roche <eroche@redhat.com>
Co-authored-by: Emma Roche <eroche@redhat.com>
rules are written and up to date. Signed-off-by: Zdenek Kraus <zkraus@redhat.com>
|
Now it is rebase to the latest main, Sorry about that. No other code changes. |
4 participants
This is a team wide open PR, please do suggest addition, edits, anything that you thing might be useful for this guide.
Design guide is suppose to be a set of guidelines and tips on how to design tests, write commits, submit a review PRs, and anything that might be useful.