Add $bytes_received to log number of (body) bytes read from client, fixes #892.#893
Open
fredrikekre wants to merge 1 commit intomasterfrom
Open
Add $bytes_received to log number of (body) bytes read from client, fixes #892.#893fredrikekre wants to merge 1 commit intomasterfrom
fredrikekre wants to merge 1 commit intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #893 +/- ##
==========================================
+ Coverage 80.12% 80.35% +0.23%
==========================================
Files 36 36
Lines 2878 2897 +19
==========================================
+ Hits 2306 2328 +22
+ Misses 572 569 -3 ☔ View full report in Codecov by Sentry. |
f78460c to
b2f9e7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NGINX
$bytes_receivedincludes header bytes as well, I think (http://nginx.org/en/docs/stream/ngx_stream_core_module.html#var_bytes_received) so perhaps this should be called$body_bytes_receieved? Or perhaps this should be updated to also count header bytes. (NGINX doesn't have$body_bytes_receieved.)