[JuliaLowering] Misc. cleanup: symboliclabel, flatten_blocks#61166
Open
mlechu wants to merge 3 commits intoJuliaLang:masterfrom
Open
[JuliaLowering] Misc. cleanup: symboliclabel, flatten_blocks#61166mlechu wants to merge 3 commits intoJuliaLang:masterfrom
symboliclabel, flatten_blocks#61166mlechu wants to merge 3 commits intoJuliaLang:masterfrom
Conversation
Keno
approved these changes
Feb 26, 2026
Member
|
(reviewed the labeled break specific parts only) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc:
_typeof_captured_variablein closure conversionex.toplevel_purein scope resolutionflatten_blocksto make debug output more readable.an accepted form in flisp lowering).
Fixups to #60481 and #61016
special-cased
forms can show up where. I can sympathize, and will hopefully have that
written down sometime this week.
@labelmacro---I could fix the mistakes, it'sjust certain that we need everything to work without them, and having them was
masking some problems.
loop-cont/loop-exitin the normal macro andloop_cont/loop_exitwas pretty deviousFor future reference, these are the invariants we have and want to maintain:
expr_to_est(equivalent_old_expansion)(modulo scope layer nonsense)JuliaLowering
scope_layer/name-mangling equivalence
valid_st1and went throughest_to_dst; no other forms are possibleAtop #61133