REPL: Convert char to string before calling escape_string#61143
Open
DilumAluthge wants to merge 1 commit intomasterfrom
Open
REPL: Convert char to string before calling escape_string#61143DilumAluthge wants to merge 1 commit intomasterfrom
escape_string#61143DilumAluthge wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this function,
keyis allowed to be eitherStringorChar, but there is no method matchingescape_string(::Char). So convertkeyto a string before callingescape_string.MWE:
Which throws this error:
But we want it to throw this instead:
Detected by JET.