Skip to content

fix: restore GENERATED ALWAYS AS IDENTITY parsing #2397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dengliming wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −1
Open

fix: restore GENERATED ALWAYS AS IDENTITY parsing #2397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9705,7 +9705,7 @@ List<String> CreateParameter():
| tk=<K_TYPE> | tk=<K_COMMENT> | tk=<K_USING> | tk=<K_COLLATE> | tk=<K_ASC>
| tk=<K_DESC> | tk=<K_TRUE> | tk=<K_FALSE> | tk=<K_PARALLEL> | tk=<K_BINARY> | tk=<K_START> | tk=<K_ORDER>
| tk=<K_TIME_KEY_EXPR> | tk=<K_RAW> | tk=<K_HASH> | tk=<K_FIRST> | tk=<K_LAST> | tk = <K_SIGNED> | tk = <K_UNSIGNED>
| tk=<K_ENGINE> | tk=<K_IDENTITY> | tk=<K_MATERIALIZED> | tk=<K_SAMPLE>
| tk=<K_ENGINE> | tk=<K_IDENTITY> | tk=<K_MATERIALIZED> | tk=<K_SAMPLE> | tk=<K_ALWAYS>
| tk="="
)
{ param.add(tk.image); }
Expand Down
12 changes: 12 additions & 0 deletions src/test/java/net/sf/jsqlparser/statement/create/CreateTableTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,6 +926,18 @@ public void testCreateTableIssue1230() throws JSQLParserException {
"CREATE TABLE TABLE_HISTORY (ID bigint generated by default as identity, CREATED_AT timestamp not null, TEXT varchar (255), primary key (ID))");
}

@Test
public void testCreateTableGeneratedAlwaysAsIdentityRegression() throws JSQLParserException {
assertSqlCanBeParsedAndDeparsed(
"create table if not exists book_type ( id bigint not null generated always as identity )");
}

@Test
public void testCreateTableGeneratedByDefaultAsIdentityRegression() throws JSQLParserException {
assertSqlCanBeParsedAndDeparsed(
"create table if not exists book_type ( id bigint not null generated by default as identity )");
}

@Test
public void testCreateUnionIssue1309() throws JSQLParserException {
assertSqlCanBeParsedAndDeparsed(
Expand Down