Fix AE2 Things mod ID#813
Merged
zyxkad merged 1 commit intoIntelligenceModding:dev/1.21.1from Mar 27, 2026
Merged
Conversation
The mod ID of AE2 Things is `ae2things`. Ref: https://github.com/Technici4n/AE2Things-Forge/blob/4f2503cca033526a1299c800878360994d3649f1/src/main/java/io/github/projectet/ae2things/AE2Things.java#L38 Signed-off-by: Dongruixuan Li <dongruixuan@hotmail.com>
Contributor
Build PreviewYou can find files attached to the below linked Workflow Run URL (Logs).
|
Collaborator
|
thanks for the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION
What kind of change does this PR introduce? (Bug fix, feature, ...)
This PR fixes the mod ID of AE2 Things, it's
ae2thingsnotae2_things. Ref: https://github.com/Technici4n/AE2Things-Forge/blob/4f2503cca033526a1299c800878360994d3649f1/src/main/java/io/github/projectet/ae2things/AE2Things.java#L38.What is the current behavior? (You can also link to an open issue here)
Currently if we have a 256k item cell from AE2 Things, it won't be shown in
getCellscall, due to theAPAddon.AE2_THINGS.isLoaded()returns false even though it's loaded (ref).What is the new behavior (if this is a feature change)?
It will be correctly shown.
Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
No.