Skip to content

Add state to Geoscanner return#806

Merged
zyxkad merged 6 commits intoIntelligenceModding:dev/0.8-1.21.1from
Da5h1n:dev/1.21.1
Mar 27, 2026
Merged

Add state to Geoscanner return#806
zyxkad merged 6 commits intoIntelligenceModding:dev/0.8-1.21.1from
Da5h1n:dev/1.21.1

Conversation

@Da5h1n
Copy link
Copy Markdown

@Da5h1n Da5h1n commented Feb 4, 2026

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • Docs have been added / updated (for features or maybe bugs which were noted). If not, please update the needed documentation here. Feel free to remove this check if you don't need it
  • All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)
    Feature

  • What is the current behavior? (You can also link to an open issue here)
    Geoscanners do not return Blockstate

  • What is the new behavior (if this is a feature change)?
    Geoscanners can return Blockstate

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
    No

  • Other information:
    (my first time contributing on github, hope i done everything correctly)

zyxkad and others added 3 commits January 2, 2026 23:34
Signed-off-by: Kevin Z <zyxkad@gmail.com>
Signed-off-by: Kevin Z <zyxkad@gmail.com>
@zyxkad
Copy link
Copy Markdown
Collaborator

zyxkad commented Feb 4, 2026

Code generally looks good, just need some formatting & caching.

However, why is state needed in the result? What's the use example?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 4, 2026

Build Preview

badge

You can find files attached to the below linked Workflow Run URL (Logs).

Name Link
Commit 827244b
Logs https://github.com/IntelligenceModding/AdvancedPeripherals/actions/runs/23661858193
Jar Files AdvancedPeripherals PR 806
Expires At 2026-06-25T18:37:26Z

@SirEndii
Copy link
Copy Markdown
Member

SirEndii commented Feb 4, 2026

Check build log for checkstyle issues and resolve them

Also could you answer zyxkads question about the use case

@Da5h1n
Copy link
Copy Markdown
Author

Da5h1n commented Feb 4, 2026

that should be fixed now
and im currently using this for a 3D dashboard im working on:
image

probably not the best use case but it can probably help with waterlogged blocks and mining turtles

@Da5h1n
Copy link
Copy Markdown
Author

Da5h1n commented Feb 4, 2026

ive tested it both on turtles and as a peripheral and it works fine

@SirEndii SirEndii requested a review from zyxkad February 4, 2026 22:54
@SirEndii SirEndii added enhancement New feature or request 1.21.1 labels Feb 4, 2026
@SirEndii SirEndii moved this to Needs testing/review in Advanced Peripherals Feb 4, 2026
@SirEndii SirEndii added this to the 0.7.x milestone Feb 4, 2026
@zyxkad
Copy link
Copy Markdown
Collaborator

zyxkad commented Mar 27, 2026

Since it is a new feature, I'll merge it into 0.8.

@zyxkad zyxkad changed the base branch from dev/1.21.1 to dev/0.8-1.21.1 March 27, 2026 18:36
Signed-off-by: Kevin Z <zyxkad@gmail.com>
@zyxkad zyxkad modified the milestones: 0.7.x, 0.8r Mar 27, 2026
@zyxkad zyxkad moved this to In review in 0.8/1.0 Backlog Mar 27, 2026
@zyxkad zyxkad merged commit 76dd4ed into IntelligenceModding:dev/0.8-1.21.1 Mar 27, 2026
3 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in 0.8/1.0 Backlog Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.21.1 enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants